Put lombok in the provided scope #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The lombok annotation processor should be placed in the provided scope, so its dependency is not propagated to projects that depend on spring-content. For projects where lombok is only used in tests, it is placed in the test scope. Fixes paulcwarren#768
4f2d9d5 to
4b00b81
Compare
|
It looks like some spring-content-examples rely on that lombok on the classpath as well. |
|
Yup. I will fix those today and re-commit to get the checks green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lombok annotation processor should be placed in the provided scope,
so its dependency is not propagated to projects that depend on
spring-content.
This matches with the installation instructions: https://projectlombok.org/setup/maven
Fixes #768