Adding Oracle compatibility for JPA and Rest #545
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, looks like the Oracle tests are failing in the github actions branch build, no idea why at this stage as they pass locally. There is no Spring output in the logs to give an indication of what is happening in the test container set-up but I'm guessing it's something to do with that. I will look at it again over the weekend at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @paulcwarren, reading the contribution agreement, it asks for
@authoretc but I haven't added any additional production classes, only a few sql files. I didn't think it necessary to add@authorto test classes.EDIT: Should emphasise that these changes are using TestContainers for the Oracle tests which I know is a departure from the existing tests.