Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spring-versions-jpa-boot-starter must add additional config #82

Closed
lmtoo opened this issue Oct 12, 2019 · 2 comments
Closed

spring-versions-jpa-boot-starter must add additional config #82

lmtoo opened this issue Oct 12, 2019 · 2 comments
Labels

Comments

@lmtoo
Copy link

lmtoo commented Oct 12, 2019

when depedencies spring-versions-jpa-boot-starter and spring-boot-starter-data-jpa ,
SpringBoot application must also add @EnableJpaRepositories(basePackages = ["com.example.springcontentdemo", "org.springframework.versions"]) , the package org.springframework.versions shuld be auto include.
otherwise JpaAutoConfiguration try to generate method in LockingAndVersioningRepository ,not to delegate to LockingAndVersioningRepositoryImpl

@paulcwarren
Copy link
Owner

paulcwarren commented Oct 18, 2019

It is definitely correct that org.springframework.versions has to be in the set of base packages scanned by the spring-data in order to find the implementation class for LockingAndVersioningRepositoryImpl. This is by design by the spring data folks. We discussed this with the Spring Data team a little bit in this issue.

But, point taken on the auto-include we can see what we can do here. I am not sure how much we can influence this but we can at least investigate.

paulcwarren pushed a commit that referenced this issue Jan 25, 2020
…guration packages

- when jpa versions boot starer is added to the classpath
- so that the LockingAndVersioningRepository fragment is found with the need for developer configuration

Fixes #82
@paulcwarren
Copy link
Owner

Fixed by this commit in this build.

Available in the lastest 1.0.0.M6-SNAPSHOT.

paulcwarren pushed a commit that referenced this issue Oct 27, 2021
…guration packages

- when jpa versions boot starer is added to the classpath
- so that the LockingAndVersioningRepository fragment is found with the need for developer configuration

Fixes #82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants