Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3StoreConfigurer vs. deprecated S3ObjectIdResolver #495

Closed
martinsefcik opened this issue Feb 10, 2021 · 1 comment · Fixed by #497
Closed

S3StoreConfigurer vs. deprecated S3ObjectIdResolver #495

martinsefcik opened this issue Feb 10, 2021 · 1 comment · Fixed by #497

Comments

@martinsefcik
Copy link

As S3ObjectIdResolver class is marked as deprecated wouldn't it be nicer to add some empty default implementation for configureS3ObjectIdResolvers method in S3StoreConfigurer interface.
So we don't have to implement this method every time during creating implementation for S3StoreConfigurer.

public S3StoreConfigurer configurer() {
    return new S3StoreConfigurer() {

            @Override
            public void configureS3StoreConverters(ConverterRegistry registry) {
                registry.addConverter(...);
            }

===>        @Override
===>        public void configureS3ObjectIdResolvers(S3ObjectIdResolvers resolvers) {
===>            // deprecated
===>        }

        };
}
@paulcwarren
Copy link
Owner

Thanks for the suggestion @martinsefcik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants