Skip to content
This repository has been archived by the owner on Oct 1, 2024. It is now read-only.

Bump compiler #96

Merged
merged 5 commits into from
Sep 19, 2019
Merged

Bump compiler #96

merged 5 commits into from
Sep 19, 2019

Conversation

clbarnes
Copy link
Collaborator

@clbarnes clbarnes commented Sep 18, 2019

Resolves #93

  • Updates docs to reflect maturin usage
  • Bumps versions of pyo3 and numpy(rust)
  • Uses the oldest pyo3-compatible compiler
  • Travis tests against release builds

@clbarnes clbarnes mentioned this pull request Sep 18, 2019
@pattonw
Copy link
Owner

pattonw commented Sep 18, 2019

awesome, thanks for figuring this out Chris. It looks like the pyo3 and numpy are being updated quickly so hopefully we won't be stuck with nightly for too long.

@clbarnes
Copy link
Collaborator Author

The nightly requirement is unfortunately blocked by a rust feature with no timeline for stabilisation (I linked the tracking issue in #93).

@pattonw
Copy link
Owner

pattonw commented Sep 19, 2019

This all looks pretty good to me, can I go ahead and merge it?

@clbarnes
Copy link
Collaborator Author

clbarnes commented Sep 19, 2019

Yep! I don't think there's anything else to change in the docs right now. I think the deploy stage still isn't running, though.

@pattonw
Copy link
Owner

pattonw commented Sep 19, 2019

Yeah, the deploy stage still isn't running, but I can try to sort that out later

@pattonw pattonw merged commit f7ee234 into pattonw:master Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with reading n5 array
2 participants