Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(linting): resolve warnings being flagged by the linter #26

Conversation

wise-king-sullyman
Copy link
Contributor

Closes #25

Disabled no-explicit-any as I feel explicit any can have value. If you'd rather we just disable no-exhaustive-deps as well I'm happy to do that and revert the changes to Xterm and SpiceConsole.

Alternatively if you think no-explicit-any should be enabled we can go that route too.

@wise-king-sullyman wise-king-sullyman merged commit bcdeec6 into patternfly:main Feb 27, 2023
@wise-king-sullyman wise-king-sullyman deleted the resolve-linting-warnings branch February 27, 2023 16:28
@github-actions
Copy link

🎉 This PR is included in version 4.95.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve warnings being flagged by the linter
2 participants