fix(ClipboardCopy): Add string[] type to children #11177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview: https://patternfly-react-pr-11177.surge.sh A11y report: https://patternfly-react-pr-11177-a11y.surge.sh |
ce0fdf3 to
f1671dd
Compare
|
Actually it doesn't handle it correctly for some reason. @tlabaj do you happen to know what's happening?
|
f1671dd to
1325248
Compare
|
Ah nvm found the issue, was inside |
tlabaj
reviewed
Jan 14, 2025
3ec6591 to
8e6dd02
Compare
The ClipboardCopy component already handles string[] but didn't have it written in the props as valid.
8e6dd02 to
cb3204f
Compare
|
@tlabaj I've updated and fixed tests. It does fail atm but I do not understand why as the Jest docs claims it should work https://jestjs.io/docs/expect#tohavebeencalledwitharg1-arg2- I have trouble getting jest to work locally unfortunately as it keeps giving me this error, so debugging is a bit time consuming for me. Could you fix it instead or let me know if I missed a step in preparing my dev environment? FAIL packages/react-core/src/deprecated/components/Modal/__tests__/ModalBoxDescription.test.tsx
● Test suite failed to run
Cannot find module '@patternfly/react-styles' from 'packages/react-core/src/deprecated/components/Modal/ModalBoxDescription.tsx'
Require stack:
packages/react-core/src/deprecated/components/Modal/ModalBoxDescription.tsx
packages/react-core/src/deprecated/components/Modal/__tests__/ModalBoxDescription.test.tsx
1 | import * as React from 'react';
> 2 | import { css } from '@patternfly/react-styles'; |
packages/react-core/src/components/ClipboardCopy/__tests__/ClipboardCopy.test.tsx
Outdated
Show resolved
Hide resolved
tlabaj
approved these changes
Jan 24, 2025
dlabaj
approved these changes
Jan 24, 2025
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ClipboardCopy component already handles string[] but didn't have it written in the props as valid.
What: Closes #11186
Additional issues: