Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal - heading level prop #1736

Closed
jgiardino opened this issue Apr 9, 2019 · 0 comments · Fixed by #1942
Closed

Modal - heading level prop #1736

jgiardino opened this issue Apr 9, 2019 · 0 comments · Fixed by #1942
Assignees
Labels
Milestone

Comments

@jgiardino
Copy link
Collaborator

Currently, modals in core use <h1> as the heading level, but the react components have this set to <h3>.

There is some discussion related to what the recommended levels should be here:
w3c/aria-practices#551 (comment)

For this issue, we should provide a prop to allow consumers to change the level, and use a default value based on the recommendation by the aria-practices group.

For our default I'd suggest <h1> unless someone has a strong reason for <h2>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants