-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating the bullet chart design pattern #697
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bmignano Thanks for submitting this. I have to admit to not being that familiar with how these bullet charts are used, but I was confused by your description of the "Measure Greater the Max Range" variation that was added. Isn't the blue bar the value and the gray bar the range? Your call outs seem to have these reversed. Not sure. A couple other small things--
-
Should add another jump link at the top of the design page.
-
The mockups on the Overview page should not have callouts as there is nothing for the callouts to reference. This was an oversite with the current documentation, but perhaps you can fix while you are in here.
@mcarrano Great catch! I accidentally reversed the callouts, my mistake. Will fix that and address your other comments once all the reviews are in. Thanks! |
Thought this was in pretty good shape overall so I went ahead and made @mcarrano 's changes. @beanh66 @serenamarie125 @mcarrano Please review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @bmignano ! Thanks for making the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@mcarrano @beanh66 You both already approved, but I just had to make one small change – added a comma after the new jump link on the design page. Just waiting for review from @serenamarie125. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I'm still good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for reviewing @serenamarie125 . I will merge. |
Description
Updating the bullet chart design pattern to match changes needed due to pattern implementation
JIRA: https://patternfly.atlassian.net/browse/OSUX-665
Closes: #662
Changes
Contribution Submission Checklist