Update applauncher masthead

[mcoker]

Description

Update masthead in app launcher examples to reflect new masthead design http://www.patternfly.org/pattern-library/application-framework/masthead/#design

fixes patternfly/patternfly#1031

Changes

Write a list of changes the PR introduces

• remove caret from help menu
• change app launcher dropdown menu from infotip to standard dropdown
• update app launcher's hover/open states to match the help and user links

Link to rawgit and/or image

https://rawgit.com/michael-coker/patternfly/update-applauncher-masthead-dist/dist/tests/application-launcher.html

PR checklist (if relevant)

• Cross browser: works in IE9
• Cross browser: works in IE10
• Cross browser: works in IE11
• Cross browser: works in Edge
• Cross browser: works in Chrome
• Cross browser: works in Firefox
• Cross browser: works in Safari
• Cross browser: works in Opera
• Responsive: works in extra small, small, medium and large view ports.
• Preview the PR: An image or a URL for designer to preview this PR is provided.

[mcoker]

@mcarrano @matthewcarleton @jeff-phillips-18 @jgiardino would someone mind reviewing this PR?

[mcarrano]

Looks good @michael-coker except that it looks like on the tall masthead versions the User menu (i.e Brain Johnson) is lower than the two icon menus to the left. Can you check that? Might be just my eyes but they don't look vertically aligned.

[mcoker]

@mcarrano it kinda looked that way to me, too. Here are a couple of screenshots with guides that show the top and bottom of the middle (help) icon. Looks like the help and user icons are aligned to the bottom of the guide in each browser, but even though they're the same font size, they're different heights (by 1px). Want me to make an adjustment?

firefox

chrome

[mcarrano]

Yes, I see what's going on @michael-coker . The other thing that adds to this illusion is that the text "Brian Johnson" is bottom aligned with the icons rather than center-aligned. Before making more changes, I'd like @kybaker to take a look. Do you feel like the user icon and/or the menu should be adjusted to make these items appear in a straight line? Or do you think it's OK as is?

[mcoker]

@mcarrano I re-worked this so the text is center aligned, but the build on Travis is failing. I believe this is the error:

compare | Chromy error: Error. See scenario – about-modal (large-device)

I pulled down master and rebased before updating the branch, but didn't change anything with the modal. @dgutride @mindreeper2420 do you know anything about that test? You can see the build output here - https://travis-ci.org/michael-coker/patternfly/builds/378927992

[mcoker]

@mcarrano the vertical alignment updates are in the latest build if you want to review - https://rawgit.com/michael-coker/patternfly/update-applauncher-masthead-dist/dist/tests/application-launcher.html

[mcarrano]

Looks great @michael-coker . Thanks for addressing the alignment.

[jeff-phillips-18]

should this be removed?

[mcoker]

Good catch! Removed.

[mcoker]

@jeff-phillips-18 @dgutride can you merge this PR?