fix(popovers): Fix color issue with bottom popover #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which numbers need to be replaced with variables? I'm not seeing any in the |
|
@mindreeper2420 you will need to create new variables for each. You'll see in the variables file there are component specific variables. We can talk about it if that is helpful, just let me know :) |
|
@matthewcarleton variables added - let me know if I missed any! :) |
|
@matthewcarleton all set - added a variable for the top position. |
Fix the bottom popover styling issue where the triangle is white, rather than grey to match the title background. fixes patternfly/patternfly#1014 Co-authored-by: Matthew Carleton <mcarleton@redhat.com>
|
@mindreeper2420 I'm good with this, but I can't approve b/c of reasons unknown to me. @andresgalante do you want to take a look and merge if it's ok? |
jeff-phillips-18
approved these changes
May 14, 2018
jeff-phillips-18
added a commit
to jeff-phillips-18/patternfly-3
that referenced
this pull request
May 23, 2018
Some RCUE sass files were not generated due to the timing of the rcue addition and modifications made in patternfly#1026
matthewcarleton
added a commit
that referenced
this pull request
May 23, 2018
fix(rcue): Adds missed changes to RCUE sass files from #1026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bottom popover styling issue where the triangle is white, rather than grey to match the title background.
fixes patternfly/patternfly#1014
Changes
Write a list of changes the PR introduces
Rawgit: https://rawgit.com/mindreeper2420/patternfly/issue-1014-dist/dist/tests/popovers.html
PR checklist (if relevant)