Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(export): Add correct names for charts token files #38

Merged
merged 1 commit into from
Apr 23, 2024
Merged

feat(export): Add correct names for charts token files #38

merged 1 commit into from
Apr 23, 2024

Conversation

wise-king-sullyman
Copy link
Contributor

Closes #15

mfrances17
mfrances17 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@mfrances17 mfrances17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

srambach
srambach approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@srambach srambach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good AFAICT! Once merged, will this automatically work from figma without any additional steps? @mfrances17 ?

@mfrances17
Copy link
Contributor

Looks good AFAICT! Once merged, will this automatically work from figma without any additional steps? @mfrances17 ?

The plugin will always export all variables but anytime you add a new set of variables it will need to be updated; it needs to handle where it needs to separate the file and the new file name(s) to which to save.

No additional steps needed, but assuming the new charts json files follow the same model as the existing ones, the instructions in the readme should be updated to include charts.json and charts.dark.json in steps 4i and 4ii, respectively. @wise-king-sullyman

@srambach srambach merged commit 98a7af8 into main Apr 23, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@wise-king-sullyman wise-king-sullyman deleted the add-charts-export-file-names-support branch April 23, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srambach srambach srambach approved these changes

@mfrances17 mfrances17 mfrances17 approved these changes

@kmcfaul kmcfaul Awaiting requested review from kmcfaul

Assignees
No one assigned
Labels
released on @prerelease
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exporter - correctly name additional collections files
3 participants
@wise-king-sullyman @mfrances17 @srambach