Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tokens): update and add box-shadow to matcher #29

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

srambach
Copy link
Member

@srambach srambach commented Apr 1, 2024

Update to get a change in Figma from ZIndex to z-index. It also changes Multi-colored-ordered to multi-colored-ordered.
A few colors are tweaked.

Important: This also adds box-shadow to the matcher in build.js. This is necessary to match the semantic and base tokens properly for box-shadow. HOWEVER, it also has the side effect of adding "px" to the box-shadow COLOR tokens that should not have them. This can easily be removed manually but until fixed we need to remember to do it.

@srambach srambach requested a review from mcoker April 1, 2024 18:28
@srambach srambach merged commit d277ce3 into patternfly:main Apr 5, 2024
3 checks passed
@srambach srambach mentioned this pull request Apr 5, 2024
Copy link

github-actions bot commented Apr 5, 2024

🎉 This PR is included in version 1.0.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants