Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSA: Pattern Lab Node may have trouble installing on Windows with Node 4.X #162

Closed
bmuenzenmeyer opened this issue Oct 6, 2015 · 3 comments
Closed

PSA: Pattern Lab Node may have trouble installing on Windows with Node 4.X #162

bmuenzenmeyer opened this issue Oct 6, 2015 · 3 comments
Assignees
@bmuenzenmeyer
Labels
bug 🐛 fix / refactor 🚧

Comments

@bmuenzenmeyer
Copy link
Member

Started getting reported after I incremented the travis CI config to 4.X

https://travis-ci.org/pattern-lab/patternlab-node/builds
@bmuenzenmeyer bmuenzenmeyer self-assigned this Oct 6, 2015
@bmuenzenmeyer bmuenzenmeyer added this to the v0.13.1 milestone Oct 6, 2015
@bmuenzenmeyer
Copy link
Member Author

If anyone else has trouble building with Windows - please look here first. nodejs/node-gyp#629

@bmuenzenmeyer
Copy link
Member Author

For now - I will be reverting my own environment to pre 4.X and suggest people hold off upgrading node until the situation improves.

@bmuenzenmeyer bmuenzenmeyer mentioned this issue Oct 14, 2015
Closed
@bmuenzenmeyer bmuenzenmeyer removed this from the v0.13.1 milestone Oct 15, 2015
@bmuenzenmeyer bmuenzenmeyer changed the title Investigate broken builds on node 4.X PSA: Pattern Lab Node may have trouble installing on Windows with Node 4.X Oct 15, 2015
@bmuenzenmeyer bmuenzenmeyer mentioned this issue Nov 11, 2015
Closed
@bmuenzenmeyer
Copy link
Member Author

#180

@bmuenzenmeyer bmuenzenmeyer mentioned this issue Nov 12, 2015
Closed
bmuenzenmeyer pushed a commit that referenced this issue Feb 23, 2018
@tapio @bmuenzenmeyer
Merge pull request #162 from PirtleShell/master
4089fd5 
support for multiple --open arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels
bug 🐛 fix / refactor 🚧
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bmuenzenmeyer