-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken starter kit Twig Demo #1486
Comments
Tried with: Homepage JSON Data -> Hero Data is applied correctly but there are some issues with the structure and passing the data in Twig.
I saw that, in my installation, the I would take care of that and provide a PR in the next days - If noone is currently working on that, ok? |
Feel free to take on this issue. My experience with twig is close to zero, so I would appreciate if someone could resolve this. |
I am using Pattern Lab Node
v6.0.1
onWindows | Mac | Linux
, with Nodev16.17.0
, using aTwig
Edition.The Twig Demo is currently not working as expected. There are several issues regarding the pattern data and template loading.
Pages including templates which include other components are not referencing the data provided by the provided companion JSON file.
Expected Behavior
When I install the starter kit via
patternlab install --starterkits @pattern-lab/starterkit-twig-demo
it should provide a good stating point with basic components and example pages.Twig files provided under pages should include templates which correctly consume the companion JSON.
For example: The data of homepage.json should correctly be used in
pages/homepage.twig
which includestemplates/homepage.twig
Actual Behavior
I can install the starter kit, but the JSON data from pages is not applied to the output.
Steps to Reproduce
npm create pattern-lab
patternlab install --starterkits @pattern-lab/starterkit-twig-demo
npm run start
The text was updated successfully, but these errors were encountered: