Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality for servers, templates, webhooks #32

Merged
merged 6 commits into from
Sep 3, 2024
Merged

Add functionality for servers, templates, webhooks #32

merged 6 commits into from
Sep 3, 2024

Conversation

JennyShuZhan
Copy link
Contributor

  • Create webhook
  • Create server
  • Get/delete suppressions
  • Push templates to another server

pastjean
pastjean reviewed Sep 3, 2024
View reviewed changes
Copy link
Owner

@pastjean pastjean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that's quite extensive, will definitely approve and merge in. Seems like you use isize for a bunch of IDs, could they be usize instead? (is it for "ease of use" with other APIs or because I've used isize before?

@pastjean
Copy link
Owner

pastjean commented Sep 3, 2024

neverming my comment, I used isize in other places in this repo, this goes in, I'll release a new major version since there's an API breaking change

@pastjean pastjean merged commit 24bed29 into pastjean:main Sep 3, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pastjean pastjean pastjean approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JennyShuZhan @pastjean