Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to pyproject.toml #80

Merged
merged 44 commits into from
Feb 2, 2023
Merged

Move to pyproject.toml #80

merged 44 commits into from
Feb 2, 2023

Conversation

dbrakenhoff
Copy link
Member

@dbrakenhoff dbrakenhoff commented Jan 19, 2023

Note: I accidentally added everything to this PR.

So this does a bunch of stuff:

  • add support for pastas>=0.23
    • remove usage of ps.TimeSeries objects
    • add pastas.validate_oseries and pastas.validate_stresses options (can be turned on/off on method and connector level)
  • move to pyproject.toml
  • test pastastore against multiple versions of pastas (currently 0.22.0 (master) and 0.23.0 (dev))
  • drop official testing for arctic and pystore (this was making my life difficult). All the code and tests are still available but are not run automatically on GH. It is therefore recommended to use PasConnnector.
  • update notebooks
  • update tests

Closes:

@dbrakenhoff
Copy link
Member Author

Note: the tests will not pass until some of pastas current PRs are merged.

- support pastas >= 0.23.0, with backwards compatibility
Copy link
Contributor

@martinvonk martinvonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lot of changes, also formatting related so difficult to judge. I don't have that much knowledge on what was in old pasfiles (pastas=<0.22.0) and what is new (pastas>0.22.0) and how that affects Pastastore but it looks like you thought about it and did a good job :)

See my comments on dynamic version and readme control. Could be an option right?

pyproject.toml Outdated Show resolved Hide resolved
connectors.md Show resolved Hide resolved
add dynamic versioning
@martinvonk
Copy link
Contributor

All done, you can merge this whenever you like @dbrakenhoff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants