-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to pyproject.toml #80
Conversation
set rfunc to None
resample time series before putting in store
- add support for Pastas versions - update Connector global settings names - add option to use pastas validation on series (both on method and connector level) - remove TimeSeries - point to _series_original for pastas >0.23
- was checking against wrong pastas version
Note: the tests will not pass until some of pastas current PRs are merged. |
- support pastas >= 0.23.0, with backwards compatibility
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lot of changes, also formatting related so difficult to judge. I don't have that much knowledge on what was in old pasfiles (pastas=<0.22.0) and what is new (pastas>0.22.0) and how that affects Pastastore but it looks like you thought about it and did a good job :)
See my comments on dynamic version and readme control. Could be an option right?
add dynamic versioning
All done, you can merge this whenever you like @dbrakenhoff |
Note: I accidentally added everything to this PR.
So this does a bunch of stuff:
PasConnnector
.Closes:
validate_oseries
andvalidate_stress
options when adding time series #76