Automated Label Placement #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrakenhoff
reviewed
Apr 28, 2022
dbrakenhoff
reviewed
Apr 28, 2022
dbrakenhoff
reviewed
Apr 28, 2022
most of the requirements are already included via the pastas requirement
dbrakenhoff
reviewed
Apr 28, 2022
dbrakenhoff
reviewed
Apr 28, 2022
…xt test the old label method is already tested in test_map_oseries()
dbrakenhoff
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an option for smart label placement using the adjustText package. Currently labels are only placed using an offset but that can cause labels to overlap:
The
adjust_textfunction from adjustText uses an iterative adjustment for label positions to minimize overlaps.In this example the
adjust_textfunction is relatively slow (<1min) but in problems with fewer points and shorter label strings it is much fasterThis does create an extra dependency but the adjustText package is really small and we already support all it's dependencies.