Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Checks for TarsoModel #51

Merged
merged 6 commits into from
Dec 10, 2021
Merged

Correct Checks for TarsoModel #51

merged 6 commits into from
Dec 10, 2021

Conversation

martinvonk
Copy link
Contributor

The Tarsomodel uses the same type of stresses as a RechargeModel, namely prec and evap. That means that if the stressmodel is TarsoModel, the same checks need to be done as RechargeModel, not other stressmodels.

@martinvonk martinvonk marked this pull request as draft December 9, 2021 11:05
dbrakenhoff
dbrakenhoff reviewed Dec 9, 2021
View reviewed changes
pastastore/base.py Outdated Show resolved Hide resolved
@martinvonk martinvonk marked this pull request as ready for review December 10, 2021 10:16
dbrakenhoff
dbrakenhoff reviewed Dec 10, 2021
View reviewed changes
pastastore/base.py Outdated Show resolved Hide resolved
dbrakenhoff
dbrakenhoff approved these changes Dec 10, 2021
View reviewed changes
Copy link
Member

@dbrakenhoff dbrakenhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dbrakenhoff dbrakenhoff merged commit e1a1521 into dev Dec 10, 2021
@dbrakenhoff dbrakenhoff deleted the tarso branch December 10, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrakenhoff dbrakenhoff dbrakenhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinvonk @dbrakenhoff