This repository has been archived by the owner on Sep 29, 2024. It is now read-only.
Verify CA from on-disk file #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert part of #213 again, because `SSL_CTX_load_verify_locations` is just more reliable at setting up the trust store. It looks like it's able to reference the .pem multiple times in those cases where the root issuer of the CA is also embedded in the file (which is the case with e.g. Let's Encrypt). This is better than the current implementation, and I couldn't easily find a way to do the same in-memory. I'd rather use the standard API here. See 7a85d3c
|
So the CA certificate is written to disk, but the client certificate and client private key are not written to disk (used from memory instead). I think that's a good idea -- it's okay for the CA certificate to be exposed this way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert part of #213 again, because
SSL_CTX_load_verify_locationsis just more reliable at setting up the trust store.
It looks like it's able to reference the .pem multiple times in
those cases where the root issuer of the CA is also embedded in
the file (which is the case with e.g. Let's Encrypt).
This is better than the current implementation, and I couldn't
easily find a way to do the same in-memory. I'd rather use the
standard API here.
See 7a85d3c
cc @roop