Skip to content
This repository has been archived by the owner on Sep 29, 2024. It is now read-only.

SAN host check #168

Merged
merged 7 commits into from
May 8, 2020
Merged

SAN host check #168

merged 7 commits into from
May 8, 2020

Conversation

jaroslavas
Copy link
Contributor

This PR adds an option to check if server certificate contains host in SAN field. It makes possible to use multi-domain certificates safely.
To use this feature, just enable it in configuration builder:

configurationBuilder.checksSANHost = true
configurationBuilder.sanHost = "your-vpn-server-domain.com"

@keeshux keeshux added the enhancement New feature or request label May 4, 2020
jaroslavas referenced this pull request in ProtonVPN/ios-app May 6, 2020
@keeshux keeshux self-assigned this May 8, 2020
@keeshux keeshux added this to the 2.2.4 milestone May 8, 2020
Copy link
Member

@keeshux keeshux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a comment about a type warning.

@keeshux keeshux merged commit 1ceeb8d into passepartoutvpn:master May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants