Skip to content
This repository has been archived by the owner on Sep 29, 2024. It is now read-only.

Can't handle PEM with descriptive preamble #78

Closed
keeshux opened this issue Mar 29, 2019 · 0 comments
Closed

Can't handle PEM with descriptive preamble #78

keeshux opened this issue Mar 29, 2019 · 0 comments
Assignees
@keeshux
Labels
bug Something isn't working
Milestone
1.6.0

Comments

@keeshux
Copy link
Member

keeshux commented Mar 29, 2019 •
edited
Loading

Should strip everything before BEGIN in the first place.
@keeshux keeshux added the bug Something isn't working label Mar 29, 2019
@keeshux keeshux added this to the 1.5.2 milestone Mar 29, 2019
@keeshux keeshux self-assigned this Mar 29, 2019
@keeshux keeshux changed the title Can't handle certificates with descriptive header Can't handle PEM with descriptive preamble Mar 29, 2019
@keeshux keeshux modified the milestones: 1.5.2, 1.5.3 Apr 1, 2019
@keeshux keeshux closed this as completed in 22f8073 Apr 1, 2019
keeshux added a commit that referenced this issue Apr 2, 2019
@keeshux
Don't parse a block begin while inside a block
ccb6329 
If a PEM contained anything like <foobar>, the parser was doomed.

Fixes #78
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keeshux keeshux

Labels
bug Something isn't working
Projects
None yet
Milestone
1.6.0
Development

No branches or pull requests
1 participant
@keeshux