Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move refund detection inside ProductManager #246

Merged
merged 2 commits into from
Nov 6, 2022
Merged

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Nov 6, 2022

Revisit resolution of #238, because checking on scene active/inactive is fragile. Instead, react to IAP events.

Compare former value and report refund event via subject.
@keeshux keeshux added the bug Something isn't working label Nov 6, 2022
@keeshux keeshux added this to the 2.1.0 milestone Nov 6, 2022
@keeshux keeshux self-assigned this Nov 6, 2022
@keeshux keeshux merged commit 7ed2755 into master Nov 6, 2022
@keeshux keeshux deleted the fix-refund-detection branch November 6, 2022 17:51
optionalendeavors pushed a commit to optionalendeavors/passepartout-apple that referenced this pull request Feb 7, 2024
…ates, etc.

Merge commit '1b704d7d4aeb5765842422183c76f5f26f1d48d5'

* commit '1b704d7d4aeb5765842422183c76f5f26f1d48d5': (474 commits)
  Decouple VPNManager from TunnelKit (passepartoutvpn#248)
  Move refund detection inside ProductManager (passepartoutvpn#246)
  Full OpenVPN XOR patch (passepartoutvpn#245)
  Bump version
  Fix missing identity for beta tag
  Update CHANGELOG
  Ukrainian transaltion (passepartoutvpn#243)
  Attempt beta release
  Annotate public beta tags
  Bump version
  [ci skip] Set release date
  Update CHANGELOG
  Freeze release workflow (passepartoutvpn#242)
  Update TunnelKit with .killSwitch option
  Run tests on PR (passepartoutvpn#241)
  Retain original filename as imported profile name (passepartoutvpn#240)
  Upgrade project to Xcode 14
  Attempt beta release
  Revisit pull section in OpenVPN Endpoint
  Attempt beta release
  ...

# Conflicts:
#	CHANGELOG.1.ios.md
#	CHANGELOG.1.mac.md
#	Config.xcconfig
#	Passepartout.xcodeproj/project.pbxproj
#	Passepartout.xcodeproj/xcshareddata/xcschemes/Passepartout.xcscheme
#	Passepartout/App/Info.plist
#	Passepartout/App/iOS/fastlane/metadata/de-DE/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/el/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/en-US/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/es-MX/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/fr-FR/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/it/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/nl-NL/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/pl/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/pt-BR/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/ru/release_notes.txt
#	Passepartout/App/iOS/fastlane/metadata/sv/release_notes.txt
#	Passepartout/App/macOS/App.entitlements
#	Passepartout/App/macOS/Info.plist
#	Passepartout/App/macOS/Launcher/AppDelegate.swift
#	Passepartout/App/macOS/fastlane/metadata/de-DE/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/el/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/en-US/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/es-MX/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/fr-FR/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/it/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/nl-NL/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/pl/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/pt-BR/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/ru/release_notes.txt
#	Passepartout/App/macOS/fastlane/metadata/sv/release_notes.txt
#	Passepartout/Tunnel/Tunnel-iOS.entitlements
#	PassepartoutCore/Sources/PassepartoutConstants/AppConstants.swift
#	PassepartoutCore/Sources/PassepartoutConstants/GroupConstants.swift
#	PassepartoutCore/Sources/PassepartoutConstants/LocalProduct.swift
#	PassepartoutCore/Sources/PassepartoutCore/API
#	PassepartoutCore/Sources/PassepartoutCore/Model/ConnectionService+Migration.swift
#	PassepartoutCore/Sources/PassepartoutCore/Model/ProductManager.swift
#	PassepartoutCore/Tests/PassepartoutCoreTests/Resources/ConnectionService.json
#	Submodules/fastlane-ci-templates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant