(PC-32596) feat(accessibility): remove AccessibilityRole Dialog in Ap…

…pModal (#7107)
pass-culture · Oct 29, 2024 · 2b37bf5 · 2b37bf5
1 parent 473df49
commit 2b37bf5
Show file tree

Hide file tree

Showing 48 changed files with 1 addition and 139 deletions.
diff --git a/..._/features/accessibility/components/AccessibilityFiltersModal.native.test.tsx.native-snap b/..._/features/accessibility/components/AccessibilityFiltersModal.native.test.tsx.native-snap
@@ -65,7 +65,6 @@ exports[`<AccessibilityFiltersModal /> should render modal correctly 1`] = `
   <Modal
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     animationType="none"
     deviceHeight={1334}
     deviceWidth={750}
@@ -142,7 +141,6 @@ exports[`<AccessibilityFiltersModal /> should render modal correctly 1`] = `
     <View
       accessibilityLabelledBy="testUuidV4"
       accessibilityModal={true}
-      accessibilityRole="none"
       deviceHeight={1334}
       deviceWidth={750}
       hideModalContentWhileAnimating={false}

diff --git a/...uth/pages/signup/SignupConfirmationEmailSent/EmailResendModal.native.test.tsx.native-snap b/...uth/pages/signup/SignupConfirmationEmailSent/EmailResendModal.native.test.tsx.native-snap
@@ -4,7 +4,6 @@ exports[`<EmailResendModal /> should render correctly 1`] = `
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -81,7 +80,6 @@ exports[`<EmailResendModal /> should render correctly 1`] = `
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}

diff --git a/...p/SignupConfirmationEmailSent/SignupConfirmationEmailSentPage.native.test.tsx.native-snap b/...p/SignupConfirmationEmailSent/SignupConfirmationEmailSentPage.native.test.tsx.native-snap
@@ -733,7 +733,6 @@ exports[`<SignupConfirmationEmailSentPage /> should render correctly 1`] = `
       <Modal
         accessibilityLabelledBy="testUuidV4"
         accessibilityModal={true}
-        accessibilityRole="none"
         animationType="none"
         deviceHeight={1334}
         deviceWidth={750}

diff --git a/...shots__/features/bookings/pages/BookingDetails/BookingDetails.native.test.tsx.native-snap b/...shots__/features/bookings/pages/BookingDetails/BookingDetails.native.test.tsx.native-snap
@@ -1390,7 +1390,6 @@ exports[`BookingDetails should render correctly 1`] = `
   <Modal
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     animationType="none"
     deviceHeight={1334}
     deviceWidth={750}
@@ -1421,7 +1420,6 @@ exports[`BookingDetails should render correctly 1`] = `
   <Modal
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     animationType="none"
     deviceHeight={1334}
     deviceWidth={750}

diff --git a/__snapshots__/features/cookies/pages/CookiesConsent.native.test.tsx.native-snap b/__snapshots__/features/cookies/pages/CookiesConsent.native.test.tsx.native-snap
@@ -4,7 +4,6 @@ exports[`<CookiesConsent/> should render correctly 1`] = `
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -81,7 +80,6 @@ exports[`<CookiesConsent/> should render correctly 1`] = `
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}

diff --git a/__snapshots__/features/home/components/modules/video/VideoModal.native.test.tsx.native-snap b/__snapshots__/features/home/components/modules/video/VideoModal.native.test.tsx.native-snap
@@ -4,7 +4,6 @@ exports[`VideoModal should render correctly if modal visible 1`] = `
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -83,7 +82,6 @@ exports[`VideoModal should render correctly if modal visible 1`] = `
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}

diff --git a/__snapshots__/features/home/pages/Home.native.test.tsx.native-snap b/__snapshots__/features/home/pages/Home.native.test.tsx.native-snap
@@ -311,7 +311,6 @@ exports[`Home page should render correctly 1`] = `
                   <Modal
                     accessibilityLabelledBy="testUuidV4"
                     accessibilityModal={true}
-                    accessibilityRole="none"
                     animationType="none"
                     deviceHeight={1334}
                     deviceWidth={750}
@@ -626,7 +625,6 @@ exports[`Home page should render correctly 1`] = `
   <Modal
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     animationType="none"
     deviceHeight={1334}
     deviceWidth={750}

diff --git a/__snapshots__/features/home/pages/ThematicHome.native.test.tsx.native-snap b/__snapshots__/features/home/pages/ThematicHome.native.test.tsx.native-snap
@@ -678,7 +678,6 @@ exports[`ThematicHome should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}
@@ -709,7 +708,6 @@ exports[`ThematicHome should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}
@@ -740,7 +738,6 @@ exports[`ThematicHome should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}
@@ -771,7 +768,6 @@ exports[`ThematicHome should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}

diff --git a/__snapshots__/features/identityCheck/components/modals/DMSModal.native.test.tsx.native-snap b/__snapshots__/features/identityCheck/components/modals/DMSModal.native.test.tsx.native-snap
@@ -4,7 +4,6 @@ exports[`<DMSModal/> should render correctly 1`] = `
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -81,7 +80,6 @@ exports[`<DMSModal/> should render correctly 1`] = `
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}

diff --git a/...s/identityCheck/pages/identification/IdentityCheckUnavailable.native.test.tsx.native-snap b/...s/identityCheck/pages/identification/IdentityCheckUnavailable.native.test.tsx.native-snap
@@ -185,7 +185,6 @@ exports[`<IdentityCheckUnavailable /> should render correctly 1`] = `
     <Modal
       accessibilityLabelledBy="testUuidV4"
       accessibilityModal={true}
-      accessibilityRole="none"
       animationType="none"
       deviceHeight={1334}
       deviceWidth={750}

diff --git a/...ures/identityCheck/pages/phoneValidation/CodeNotReceivedModal.native.test.tsx.native-snap b/...ures/identityCheck/pages/phoneValidation/CodeNotReceivedModal.native.test.tsx.native-snap
@@ -4,7 +4,6 @@ exports[`<CodeNotReceivedModal /> should have a different color if one attempt r
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -81,7 +80,6 @@ exports[`<CodeNotReceivedModal /> should have a different color if one attempt r
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}
@@ -525,7 +523,6 @@ exports[`<CodeNotReceivedModal /> should match snapshot 1`] = `
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -602,7 +599,6 @@ exports[`<CodeNotReceivedModal /> should match snapshot 1`] = `
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}

diff --git a/.../identityCheck/pages/phoneValidation/PhoneValidationTipsModal.native.test.tsx.native-snap b/.../identityCheck/pages/phoneValidation/PhoneValidationTipsModal.native.test.tsx.native-snap
@@ -4,7 +4,6 @@ exports[`<PhoneValidationTipsModal /> should match snapshot 1`] = `
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -81,7 +80,6 @@ exports[`<PhoneValidationTipsModal /> should match snapshot 1`] = `
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}

diff --git a/..._/features/identityCheck/pages/phoneValidation/SetPhoneNumber.native.test.tsx.native-snap b/..._/features/identityCheck/pages/phoneValidation/SetPhoneNumber.native.test.tsx.native-snap
@@ -528,7 +528,6 @@ exports[`SetPhoneNumber should match snapshot without modal appearance 1`] = `
                       <Modal
                         accessibilityLabelledBy="testUuidV4"
                         accessibilityModal={true}
-                        accessibilityRole="none"
                         animationType="none"
                         deviceHeight={1334}
                         deviceWidth={750}
@@ -620,7 +619,6 @@ exports[`SetPhoneNumber should match snapshot without modal appearance 1`] = `
                 <Modal
                   accessibilityLabelledBy="testUuidV4"
                   accessibilityModal={true}
-                  accessibilityRole="none"
                   animationType="none"
                   deviceHeight={1334}
                   deviceWidth={750}

diff --git a/...tyCheck/pages/phoneValidation/SetPhoneNumberWithoutValidation.native.test.tsx.native-snap b/...tyCheck/pages/phoneValidation/SetPhoneNumberWithoutValidation.native.test.tsx.native-snap
@@ -537,7 +537,6 @@ exports[`SetPhoneNumberWithoutValidation should match snapshot 1`] = `
                       <Modal
                         accessibilityLabelledBy="testUuidV4"
                         accessibilityModal={true}
-                        accessibilityRole="none"
                         animationType="none"
                         deviceHeight={1334}
                         deviceWidth={750}

diff --git a/...es/identityCheck/pages/phoneValidation/SetPhoneValidationCode.native.test.tsx.native-snap b/...es/identityCheck/pages/phoneValidation/SetPhoneValidationCode.native.test.tsx.native-snap
@@ -617,7 +617,6 @@ exports[`SetPhoneValidationCode should match snapshot 1`] = `
                 <Modal
                   accessibilityLabelledBy="testUuidV4"
                   accessibilityModal={true}
-                  accessibilityRole="none"
                   animationType="none"
                   deviceHeight={1334}
                   deviceWidth={750}

diff --git a/__snapshots__/features/location/components/HomeLocationModal.native.test.tsx.native-snap b/__snapshots__/features/location/components/HomeLocationModal.native.test.tsx.native-snap
@@ -4,7 +4,6 @@ exports[`HomeLocationModal should render correctly if modal visible 1`] = `
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -81,7 +80,6 @@ exports[`HomeLocationModal should render correctly if modal visible 1`] = `
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}

diff --git a/__snapshots__/features/location/components/SearchLocationModal.native.test.tsx.native-snap b/__snapshots__/features/location/components/SearchLocationModal.native.test.tsx.native-snap
@@ -63,7 +63,6 @@ exports[`SearchLocationModal should render correctly if modal visible 1`] = `
   <Modal
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     animationType="none"
     deviceHeight={1334}
     deviceWidth={750}
@@ -128,7 +127,6 @@ exports[`SearchLocationModal should render correctly if modal visible 1`] = `
     <View
       accessibilityLabelledBy="testUuidV4"
       accessibilityModal={true}
-      accessibilityRole="none"
       collapsable={false}
       deviceHeight={1334}
       deviceWidth={750}

diff --git a/__snapshots__/features/location/components/VenueMapLocationModal.native.test.tsx.native-snap b/__snapshots__/features/location/components/VenueMapLocationModal.native.test.tsx.native-snap
@@ -65,7 +65,6 @@ exports[`VenueMapLocationModal should render correctly if modal visible 1`] = `
   <Modal
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     animationType="none"
     deviceHeight={1334}
     deviceWidth={750}
@@ -142,7 +141,6 @@ exports[`VenueMapLocationModal should render correctly if modal visible 1`] = `
     <View
       accessibilityLabelledBy="testUuidV4"
       accessibilityModal={true}
-      accessibilityRole="none"
       deviceHeight={1334}
       deviceWidth={750}
       hideModalContentWhileAnimating={false}

diff --git a/...nts/SignUpSignInChoiceOfferModal/SignUpSignInChoiceOfferModal.native.test.tsx.native-snap b/...nts/SignUpSignInChoiceOfferModal/SignUpSignInChoiceOfferModal.native.test.tsx.native-snap
@@ -4,7 +4,6 @@ exports[`SignUpSignInChoiceOfferModal should match previous snapshot 1`] = `
 <Modal
   accessibilityLabelledBy="testUuidV4"
   accessibilityModal={true}
-  accessibilityRole="none"
   animationType="none"
   deviceHeight={1334}
   deviceWidth={750}
@@ -81,7 +80,6 @@ exports[`SignUpSignInChoiceOfferModal should match previous snapshot 1`] = `
   <View
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     deviceHeight={1334}
     deviceWidth={750}
     hideModalContentWhileAnimating={false}

diff --git a/__snapshots__/features/profile/pages/ChangeEmail/ChangeEmail.native.test.tsx.native-snap b/__snapshots__/features/profile/pages/ChangeEmail/ChangeEmail.native.test.tsx.native-snap
@@ -666,7 +666,6 @@ exports[`<ChangeEmail/> should render correctly 1`] = `
   <Modal
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     animationType="none"
     deviceHeight={1334}
     deviceWidth={750}

diff --git a/...ures/profile/pages/NotificationSettings/NotificationsSettings.native.test.tsx.native-snap b/...ures/profile/pages/NotificationSettings/NotificationsSettings.native.test.tsx.native-snap
@@ -2307,7 +2307,6 @@ exports[`NotificationsSettings should render correctly when user is logged in 1`
         <Modal
           accessibilityLabelledBy="testUuidV4"
           accessibilityModal={true}
-          accessibilityRole="none"
           animationType="none"
           deviceHeight={1334}
           deviceWidth={750}
@@ -4675,7 +4674,6 @@ exports[`NotificationsSettings should render correctly when user is not logged i
         <Modal
           accessibilityLabelledBy="testUuidV4"
           accessibilityModal={true}
-          accessibilityRole="none"
           animationType="none"
           deviceHeight={1334}
           deviceWidth={750}

diff --git a/...atures/search/components/sections/Accessibility/Accessibility.native.test.tsx.native-snap b/...atures/search/components/sections/Accessibility/Accessibility.native.test.tsx.native-snap
@@ -118,7 +118,6 @@ exports[`Category component should render correctly 1`] = `
   <Modal
     accessibilityLabelledBy="testUuidV4"
     accessibilityModal={true}
-    accessibilityRole="none"
     animationType="none"
     deviceHeight={1334}
     deviceWidth={750}

diff --git a/__snapshots__/features/search/pages/Search/SearchN1/SearchN1.native.test.tsx.native-snap b/__snapshots__/features/search/pages/Search/SearchN1/SearchN1.native.test.tsx.native-snap
@@ -474,7 +474,6 @@ exports[`<SearchN1/> book offerCategory should render <SearchN1 /> 1`] = `
                   <Modal
                     accessibilityLabelledBy="testUuidV4"
                     accessibilityModal={true}
-                    accessibilityRole="none"
                     animationType="none"
                     deviceHeight={1334}
                     deviceWidth={750}

diff --git a/__snapshots__/features/search/pages/SearchFilter/SearchFilter.native.test.tsx.native-snap b/__snapshots__/features/search/pages/SearchFilter/SearchFilter.native.test.tsx.native-snap
@@ -365,7 +365,6 @@ exports[`<SearchFilter/> should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}
@@ -552,7 +551,6 @@ exports[`<SearchFilter/> should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}
@@ -739,7 +737,6 @@ exports[`<SearchFilter/> should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}
@@ -926,7 +923,6 @@ exports[`<SearchFilter/> should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}
@@ -1112,7 +1108,6 @@ exports[`<SearchFilter/> should render correctly 1`] = `
           <Modal
             accessibilityLabelledBy="testUuidV4"
             accessibilityModal={true}
-            accessibilityRole="none"
             animationType="none"
             deviceHeight={1334}
             deviceWidth={750}