-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move NodeId Generation to a separate crate #484
Conversation
bc8527a
to
b947876
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #484 +/- ##
=======================================
Coverage 81.00% 81.00%
=======================================
Files 68 69 +1
Lines 18704 18704
Branches 18704 18704
=======================================
Hits 15152 15152
Misses 3110 3110
Partials 442 442 ☔ View full report in Codecov by Sentry. |
Conformance comparison report
Number passing in both: 5731 Number failing in both: 612 Number passing in Base (6dc088c) but now fail: 0 Number failing in Base (6dc088c) but now pass: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there is a better name than partiql-core
?
Perhaps we could move this type and partiql-source-map
somewhere...
Not sure TBH—happy to change if you have a suggestion.
I could see |
We talked out-of-band and thing
Sure |
Description of changes:
Moves the
NodeId
and its Id generation to a new crate,partiql-common
so that it can get consumed by multiple crates.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.