Use partiql_ast::ast::AstTypeMap for LocationMap
#394
Conversation
Addressing the comment in PR #389, this PR re-uses the `AstTypeMap` for `LocationMap` which removes a dependency to `HashMap` as `AstTypeMap` uses `IndexMap`.
partiql-ast/Cargo.toml
Outdated
| @@ -20,7 +20,7 @@ path = "src/lib.rs" | |||
| bench = false | |||
|
|
|||
| [dependencies] | |||
| indexmap = "1.9" | |||
| indexmap = { version = "1.9", default-features = false, features = ["serde"] } | |||
There was a problem hiding this comment.
You'll want to remove the unconditional features = ["serde"], since you turn it on below conditionally via serde = [... "indexmap/serde"]
There was a problem hiding this comment.
Whoops, let fix that.
Conformance comparison report
Number passing in both: 5240 Number failing in both: 1044 Number passing in Base (babd7ac) but now fail: 0 Number failing in Base (babd7ac) but now pass: 0 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
=======================================
Coverage 81.44% 81.44%
=======================================
Files 56 56
Lines 14667 14667
Branches 14667 14667
=======================================
Hits 11945 11945
Misses 2214 2214
Partials 508 508
☔ View full report in Codecov by Sentry. |
Description of changes:
Addressing the comment in PR #389, this PR re-uses the
AstTypeMapforLocationMapwhich removes a dependency toHashMapasAstTypeMapusesIndexMap.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.