Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make partiql_value::parse_ion public #294

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Make partiql_value::parse_ion public #294

merged 1 commit into from
Feb 9, 2023

Conversation

am357
Copy link
Contributor

@am357 am357 commented Feb 9, 2023

Description of changes:

Make partiql_value::parse_ion public.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@am357 am357 marked this pull request as ready for review February 9, 2023 19:45
@am357 am357 requested review from alancai98 and jpschorr and removed request for alancai98 February 9, 2023 19:45
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

Conformance comparison report

Base (7e54311) b7d76cc +/-
% Passing 79.27% 79.27% 0.00%
✅ Passing 2229 2229 0
❌ Failing 389 389 0
🔶 Ignored 194 194 0
Total Tests 2812 2812 0

Number passing in both: 2229

Number failing in both: 389

Number passing in Base (7e54311) but now fail: 0

Number failing in Base (7e54311) but now pass: 0

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 87.94% // Head: 87.94% // No change to project coverage 👍

Coverage data is based on head (7c99555) compared to base (7e54311).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files          38       38           
  Lines        9196     9196           
=======================================
  Hits         8087     8087           
  Misses       1109     1109           
Impacted Files Coverage Δ
partiql-value/src/lib.rs 92.59% <ø> (ø)
partiql-value/src/ion.rs 94.73% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@am357 am357 requested a review from alancai98 February 9, 2023 21:00
@am357 am357 merged commit b2ce0ce into main Feb 9, 2023
@am357 am357 deleted the feat-value-ion branch February 9, 2023 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants