Skip to content

Commit

Permalink
Fix off by one error when checking preconditions to lower join ON (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
jpschorr authored Feb 10, 2023
1 parent b2ce0ce commit c63109e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion partiql-logical-planner/src/lower.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1024,7 +1024,7 @@ impl<'ast> Visitor<'ast> for AstToLogical {
assert_eq!(benv.len(), 2);

let mut env = self.exit_env();
assert!((0..1).contains(&env.len()));
assert!((0..=1).contains(&env.len()));

let Join { kind, .. } = join;

Expand Down

1 comment on commit c63109e

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PartiQL (rust) Benchmark

Benchmark suite Current: c63109e Previous: b2ce0ce Ratio
parse-1 5451 ns/iter (± 171) 5606 ns/iter (± 118) 0.97
parse-15 52686 ns/iter (± 81) 52413 ns/iter (± 51) 1.01
parse-30 104196 ns/iter (± 176) 103485 ns/iter (± 83) 1.01
compile-1 16457 ns/iter (± 31) 16517 ns/iter (± 51) 1.00
compile-15 49285 ns/iter (± 426) 48863 ns/iter (± 245) 1.01
compile-30 89639 ns/iter (± 476) 89172 ns/iter (± 485) 1.01
plan-1 19392 ns/iter (± 16) 19254 ns/iter (± 50) 1.01
plan-15 362807 ns/iter (± 908) 364078 ns/iter (± 674) 1.00
plan-30 732695 ns/iter (± 1789) 734342 ns/iter (± 1627) 1.00
eval-1 21616170 ns/iter (± 178405) 21462446 ns/iter (± 158943) 1.01
eval-15 125023271 ns/iter (± 538132) 125592744 ns/iter (± 494778) 1.00
eval-30 244749685 ns/iter (± 387919) 245551563 ns/iter (± 984010) 1.00
join 13960 ns/iter (± 13) 14033 ns/iter (± 17) 0.99
simple 5413 ns/iter (± 3) 5373 ns/iter (± 7) 1.01
simple-no 2355 ns/iter (± 1) 2297 ns/iter (± 1) 1.03
numbers 107 ns/iter (± 0) 107 ns/iter (± 0) 1
parse-simple 648 ns/iter (± 0) 646 ns/iter (± 0) 1.00
parse-ion 2255 ns/iter (± 1) 2237 ns/iter (± 4) 1.01
parse-group 7594 ns/iter (± 13) 7663 ns/iter (± 12) 0.99
parse-complex 19916 ns/iter (± 43) 19188 ns/iter (± 43) 1.04
parse-complex-fexpr 30015 ns/iter (± 130) 29990 ns/iter (± 106) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.