Skip to content

Commit

Permalink
Upgrade ion-rs to 0.18 (#390)
Browse files Browse the repository at this point in the history
  • Loading branch information
jpschorr authored Jun 12, 2023
1 parent 15fe939 commit a2e6bde
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion extension/partiql-extension-ion-functions/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ itertools = "0.10.*"
unicase = "2.6"
rust_decimal = { version = "1.25.0", default-features = false, features = ["std"] }
rust_decimal_macros = "1.26"
ion-rs = "0.17"
ion-rs = "0.18"
time = { version = "0.3", features = ["macros"] }
once_cell = "1"
regex = "1.7"
Expand Down
2 changes: 1 addition & 1 deletion extension/partiql-extension-ion/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ itertools = "0.10.*"
unicase = "2.6"
rust_decimal = { version = "1.25.0", default-features = false, features = ["std"] }
rust_decimal_macros = "1.26"
ion-rs = "0.17"
ion-rs = "0.18"
time = { version = "0.3", features = ["macros"] }
once_cell = "1"
regex = "1.7"
Expand Down
3 changes: 2 additions & 1 deletion extension/partiql-extension-ion/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ mod tests {
use crate::encode::{IonEncodeError, IonEncoderBuilder, IonEncoderConfig};
use itertools::Itertools;

use ion_rs::element::writer::TextKind;
use partiql_value::{partiql_bag, partiql_list, partiql_tuple, DateTime, Value};
use rust_decimal_macros::dec;
use std::num::NonZeroU8;
Expand All @@ -27,7 +28,7 @@ mod tests {

fn encode_ion(value: &Value, encoding: Encoding) -> Result<String, IonEncodeError> {
let mut buff = vec![];
let mut writer = ion_rs::TextWriterBuilder::new()
let mut writer = ion_rs::TextWriterBuilder::new(TextKind::Compact)
.build(&mut buff)
.expect("writer");
let mut encoder = IonEncoderBuilder::new(IonEncoderConfig::default().with_mode(encoding))
Expand Down
2 changes: 1 addition & 1 deletion partiql-conformance-test-generator/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ bench = false

[dependencies]
walkdir = "2.3"
ion-rs = "0.17"
ion-rs = "0.18"
codegen = "0.2.*"
Inflector = "0.11.*"
miette = "5.*"
Expand Down
2 changes: 1 addition & 1 deletion partiql-conformance-tests/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ partiql-value = { path = "../partiql-value", version = "0.5.*" }
partiql-eval = { path = "../partiql-eval", version = "0.5.*" }
partiql-extension-ion = {path = "../extension/partiql-extension-ion", version = "0.5.*" }

ion-rs = "0.17"
ion-rs = "0.18"

regex = "1.7"
once_cell = "1"
Expand Down
2 changes: 1 addition & 1 deletion partiql-logical-planner/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ partiql-ast = { path = "../partiql-ast", version = "0.5.*" }
partiql-parser = { path = "../partiql-parser", version = "0.5.*" }
partiql-catalog = { path = "../partiql-catalog", version = "0.5.*" }
partiql-ast-passes = { path = "../partiql-ast-passes", version = "0.5.*" }
ion-rs = "0.17"
ion-rs = "0.18"
ordered-float = "3.*"
itertools = "0.10.*"
unicase = "2.6"
Expand Down
2 changes: 1 addition & 1 deletion partiql-value/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ itertools = "0.10.*"
unicase = "2.6"
rust_decimal = { version = "1.25.0", default-features = false, features = ["std"] }
rust_decimal_macros = "1.26"
ion-rs = "0.17"
ion-rs = "0.18"
time = { version = "0.3", features = ["macros"] }
once_cell = "1"
regex = "1.7"
Expand Down

1 comment on commit a2e6bde

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PartiQL (rust) Benchmark

Benchmark suite Current: a2e6bde Previous: 15fe939 Ratio
parse-1 6229 ns/iter (± 389) 6080 ns/iter (± 58) 1.02
parse-15 58816 ns/iter (± 3210) 55784 ns/iter (± 59) 1.05
parse-30 126349 ns/iter (± 6685) 112905 ns/iter (± 420) 1.12
compile-1 5268 ns/iter (± 326) 5314 ns/iter (± 22) 0.99
compile-15 41735 ns/iter (± 1991) 36802 ns/iter (± 40) 1.13
compile-30 88240 ns/iter (± 9123) 74525 ns/iter (± 61) 1.18
plan-1 24190 ns/iter (± 1570) 20232 ns/iter (± 82) 1.20
plan-15 474705 ns/iter (± 28008) 364387 ns/iter (± 1103) 1.30
plan-30 948299 ns/iter (± 40485) 739409 ns/iter (± 1554) 1.28
eval-1 24985405 ns/iter (± 1548746) 22104702 ns/iter (± 162526) 1.13
eval-15 126878607 ns/iter (± 7686760) 121983473 ns/iter (± 533637) 1.04
eval-30 237218353 ns/iter (± 9472421) 238539502 ns/iter (± 516303) 0.99
join 14649 ns/iter (± 800) 14340 ns/iter (± 44) 1.02
simple 7046 ns/iter (± 478) 7351 ns/iter (± 44) 0.96
simple-no 735 ns/iter (± 53) 634 ns/iter (± 0) 1.16
numbers 145 ns/iter (± 9) 107 ns/iter (± 0) 1.36
parse-simple 768 ns/iter (± 43) 710 ns/iter (± 3) 1.08
parse-ion 2774 ns/iter (± 183) 2638 ns/iter (± 50) 1.05
parse-group 9263 ns/iter (± 562) 8644 ns/iter (± 13) 1.07
parse-complex 25088 ns/iter (± 1698) 22227 ns/iter (± 35) 1.13
parse-complex-fexpr 42060 ns/iter (± 3227) 34834 ns/iter (± 98) 1.21

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.