Fixes list/bag ExprValue creation in plan evaluator #969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 83.11% // Head: 83.14% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
============================================
+ Coverage 83.11% 83.14% +0.02%
- Complexity 1989 1992 +3
============================================
Files 218 219 +1
Lines 15269 15269
Branches 2731 2733 +2
============================================
+ Hits 12691 12695 +4
+ Misses 1769 1765 -4
Partials 809 809
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
johnedquinn
reviewed
Jan 17, 2023
...lin/org/partiql/lang/compiler/memorydb/operators/GetByKeyProjectRelationalOperatorFactory.kt
Show resolved
Hide resolved
johnedquinn
approved these changes
Jan 18, 2023
yliuuuu
pushed a commit
that referenced
this pull request
Jan 20, 2023
* Adds IsOrderedMeta to determine if the sequence represents a bag or list * Changes AggregationFinder to not be static
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
#966
#951
Description
Description is in 966 and agg finder fix describe in 951. Peeking the sequence caused it to be instantiated prematurely, so we'll use John's original (and simpler) method of adding a meta to determine which ExprValue to create. The other fixes (it stopped at least? can't say definitively because ... nondeterministic) some nondeterministic behavior we were seeing
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
No
Any backward-incompatible changes? [YES/NO]
No
Any new external dependencies? [YES/NO]
No
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.