Use LazyThreadSafteyMode.PUBLICATION instead of NONE #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LazyThreadSafetyMode.NONE literally means that accessing the lazy value from multiple threads can cause an NPE. Unfortunately, we assumed NONE would be implemented such that a lazy value could be initialized by multiple threads without throwing an NPE, with race conditions only possibly occurring inside the initializer block. However, that is actually the behavior is for LazyThreadSafeteyMode.PUBLICATION. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Codecov Report
@@ Coverage Diff @@
## main #433 +/- ##
=========================================
Coverage 82.33% 82.33%
Complexity 1396 1396
=========================================
Files 171 171
Lines 10724 10724
Branches 1768 1768
=========================================
Hits 8830 8830
Misses 1353 1353
Partials 541 541
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alancai98
approved these changes
Sep 7, 2021
|
FWIW, without this fix I was able to reproduce the issue ~10% of the time with this code, but was never able to reproduce it with the fix. |
|
I should add; given the inconsistency of the test in the gist, I don't think we should add that test to our suite. |
alancai98
pushed a commit
that referenced
this pull request
Sep 13, 2021
LazyThreadSafetyMode.NONE literally means that accessing the lazy value from multiple threads can cause an NPE. Unfortunately, we assumed NONE would be implemented such that a lazy value could be initialized by multiple threads without throwing an NPE, with race conditions only possibly occurring inside the initializer block. However, that is actually the behavior is for LazyThreadSafeteyMode.PUBLICATION. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. (cherry picked from commit eef183c)
alancai98
pushed a commit
that referenced
this pull request
Sep 13, 2021
LazyThreadSafetyMode.NONE literally means that accessing the lazy value from multiple threads can cause an NPE. Unfortunately, we assumed NONE would be implemented such that a lazy value could be initialized by multiple threads without throwing an NPE, with race conditions only possibly occurring inside the initializer block. However, that is actually the behavior is for LazyThreadSafeteyMode.PUBLICATION. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. (cherry picked from commit eef183c)
alancai98
added a commit
that referenced
this pull request
Sep 13, 2021
LazyThreadSafetyMode.NONE literally means that accessing the lazy value from multiple threads can cause an NPE. Unfortunately, we assumed NONE would be implemented such that a lazy value could be initialized by multiple threads without throwing an NPE, with race conditions only possibly occurring inside the initializer block. However, that is actually the behavior is for LazyThreadSafeteyMode.PUBLICATION. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. (cherry picked from commit eef183c)
alancai98
added a commit
that referenced
this pull request
Sep 13, 2021
LazyThreadSafetyMode.NONE literally means that accessing the lazy value from multiple threads can cause an NPE. Unfortunately, we assumed NONE would be implemented such that a lazy value could be initialized by multiple threads without throwing an NPE, with race conditions only possibly occurring inside the initializer block. However, that is actually the behavior is for LazyThreadSafeteyMode.PUBLICATION. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. (cherry picked from commit eef183c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #367
LazyThreadSafetyMode.NONE literally means that accessing the lazy value from multiple threads can cause an NPE.
Unfortunately, we assumed NONE would be implemented such that a lazy value could be initialized by multiple
threads without throwing an NPE, with race conditions only possibly occurring inside the initializer block.
However, that is actually the behavior is for LazyThreadSafeteyMode.PUBLICATION.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.