Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to gradle to run on ParameterizedTests #338

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Conversation

alancai98
Copy link
Member

Gradle was previously not running any of the ParameterizedTests and possibly other JUnit5 tests.

Tested by running ./gradlew build with a failing ParameterizedTest to ensure the test fails appropriately.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Dec 8, 2020
@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #338 (1431770) into master (a8f59bf) will decrease coverage by 2.72%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #338      +/-   ##
============================================
- Coverage     82.37%   79.64%   -2.73%     
+ Complexity     1233     1190      -43     
============================================
  Files           157      157              
  Lines          9366     9366              
  Branches       1526     1526              
============================================
- Hits           7715     7460     -255     
- Misses         1192     1466     +274     
+ Partials        459      440      -19     
Flag Coverage Δ Complexity Δ
CLI 0.00% <ø> (-18.12%) 0.00 <ø> (ø)
EXAMPLES 0.00% <ø> (-76.02%) 0.00 <ø> (ø)
LANG 85.26% <ø> (+0.24%) 0.00 <ø> (ø)
PTS 100.00% <ø> (ø) 0.00 <ø> (ø)
TEST_SCRIPT 79.68% <ø> (ø) 0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...es/src/kotlin/org/partiql/examples/util/Example.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...s/src/kotlin/org/partiql/examples/ParserExample.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...c/kotlin/org/partiql/examples/PreventJoinVistor.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (ø%)
...lin/org/partiql/examples/EvaluationWithBindings.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...org/partiql/examples/EvaluationWithLazyBindings.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...org/partiql/examples/SimpleExpressionEvaluation.kt 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...lin/org/partiql/examples/CustomFunctionsExample.kt 0.00% <0.00%> (-92.00%) 0.00% <0.00%> (-3.00%)
.../org/partiql/examples/PartialEvaluationRewriter.kt 0.00% <0.00%> (-91.67%) 0.00% <0.00%> (-2.00%)
.../kotlin/org/partiql/examples/ParserErrorExample.kt 0.00% <0.00%> (-88.24%) 0.00% <0.00%> (-2.00%)
.../src/java/org/partiql/examples/CSVJavaExample.java 0.00% <0.00%> (-87.81%) 0.00% <0.00%> (-4.00%)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8f59bf...1431770. Read the comment docs.

@alancai98 alancai98 merged commit eb09053 into master Dec 14, 2020
@alancai98 alancai98 deleted the fix-param-test-gradle branch December 14, 2020 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants