Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/2] Removes temp SqlFnProvider #1587

Merged
merged 5 commits into from
Sep 20, 2024
Merged

[2/2] Removes temp SqlFnProvider #1587

merged 5 commits into from
Sep 20, 2024

Conversation

rchowell
Copy link
Contributor

Relevant Issues

#1584
#1496

Description

This is part 2 of 2 which removes SqlFnProvider and use of the function signature for function resolution.

Functions are simplified to,

  1. Gets functions from the catalog
  2. Uses the Function/Aggregation in the plan rather than a "specific"
  3. PlanType calls Function/Aggregation methods rather than using FnSignature fields directly.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Sep 17, 2024

CROSS-ENGINE Conformance Report ❌

BASE (LEGACY-8146A99) TARGET (EVAL-8146A99) +/-
% Passing 89.67% 94.20% 4.53% ✅
Passing 5287 5554 267 ✅
Failing 609 75 -534 ✅
Ignored 0 267 267 🔶
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 8146a99
  • Base Engine: LEGACY
  • Target Commit: 8146a99
  • Target Engine: EVAL

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing Tests. ❌
  • Passing in both: 5019
  • Failing in both: 74
  • PASSING in BASE but now FAILING in TARGET: 1
  • FAILING in BASE but now PASSING in TARGET: 535

Now Failing Tests ❌

The following 1 test(s) were previously PASSING in BASE but are now FAILING in TARGET:

Click here to see
  1. MYSQL_SELECT_29, compileOption: LEGACY

Now Passing Tests

535 test(s) were previously failing in BASE (LEGACY-8146A99) but now pass in TARGET (EVAL-8146A99). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-LEGACY Conformance Report ✅

BASE (LEGACY-4FA1A76) TARGET (LEGACY-8146A99) +/-
% Passing 89.67% 89.67% 0.00% ✅
Passing 5287 5287 0 ✅
Failing 609 609 0 ✅
Ignored 0 0 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 4fa1a76
  • Base Engine: LEGACY
  • Target Commit: 8146a99
  • Target Engine: LEGACY

Result Details

  • Passing in both: 5287
  • Failing in both: 609
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0

CROSS-COMMIT-EVAL Conformance Report ✅

BASE (EVAL-4FA1A76) TARGET (EVAL-8146A99) +/-
% Passing 94.20% 94.20% 0.00% ✅
Passing 5554 5554 0 ✅
Failing 75 75 0 ✅
Ignored 267 267 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 4fa1a76
  • Base Engine: EVAL
  • Target Commit: 8146a99
  • Target Engine: EVAL

Result Details

  • Passing in both: 5554
  • Failing in both: 75
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0

Base automatically changed from v1-fn-path to v1 September 19, 2024 19:23
@rchowell rchowell merged commit 7a07d25 into v1 Sep 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants