Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V1] Moves datum/catalog from eval/planner to spi java package #1581

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

rchowell
Copy link
Contributor

Description

  • Datum was developed in partiql-eval, but moved to partiql-spi with no package name change.
  • Catalog was developed in partiql-planner, but moved to partiql-spi with no package name change.
  • The package renames were omitted on the move to keep the diffs sane.

This PR finalizes the package names and includes the new apiDump.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Sep 16, 2024

CROSS-ENGINE Conformance Report ✅

BASE (LEGACY-ED93FFE) TARGET (EVAL-ED93FFE) +/-
% Passing 89.65% 94.20% 4.55% ✅
Passing 5286 5554 268 ✅
Failing 610 75 -535 ✅
Ignored 0 267 267 🔶
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: ed93ffe
  • Base Engine: LEGACY
  • Target Commit: ed93ffe
  • Target Engine: EVAL

Result Details

  • Passing in both: 5019
  • Failing in both: 75
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 535

Now Passing Tests

535 test(s) were previously failing in BASE (LEGACY-ED93FFE) but now pass in TARGET (EVAL-ED93FFE). Before merging, confirm they are intended to pass.

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

CROSS-COMMIT-LEGACY Conformance Report ✅

BASE (LEGACY-82AE5D9) TARGET (LEGACY-ED93FFE) +/-
% Passing 89.65% 89.65% 0.00% ✅
Passing 5286 5286 0 ✅
Failing 610 610 0 ✅
Ignored 0 0 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 82ae5d9
  • Base Engine: LEGACY
  • Target Commit: ed93ffe
  • Target Engine: LEGACY

Result Details

  • Passing in both: 5286
  • Failing in both: 610
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0

CROSS-COMMIT-EVAL Conformance Report ✅

BASE (EVAL-82AE5D9) TARGET (EVAL-ED93FFE) +/-
% Passing 94.20% 94.20% 0.00% ✅
Passing 5554 5554 0 ✅
Failing 75 75 0 ✅
Ignored 267 267 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 82ae5d9
  • Base Engine: EVAL
  • Target Commit: ed93ffe
  • Target Engine: EVAL

Result Details

  • Passing in both: 5554
  • Failing in both: 75
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0

Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rchowell rchowell merged commit 8e0afff into v1 Sep 17, 2024
14 checks passed
@rchowell rchowell deleted the v1-spi-cleanup branch September 18, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants