Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1] Upgrade to Kotlin 1.9 #1578

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[v1] Upgrade to Kotlin 1.9 #1578

merged 1 commit into from
Sep 16, 2024

Conversation

alancai98
Copy link
Member

Relevant Issues

  • None. Kotlin 1.8+ will be helpful for the other task I'm working on to add simpler AST classes, specifically support for the @Builder Lombok annotation.

Description

Upgrades v1 branch of PLK to Kotlin 1.9. Not sure yet which version of Kotlin we want to support for v1 since there are Kotlin releases after 1.9.

Summary of changes required to get existing code working

  • Upgrade related dependencies (Kotlinx coroutines, Dokka) to later version
  • Upgrade PIG dependency to 0.6.3 -- 0.6.2 does not work in Kotlin 1.7 and later since ?. operator on non-null types gives an error
  • partiql-planner relied on Dokka's relativeTo -- changed to use Kotlin standard's relativeTo
  • Re-run of apiDump since Kotlin 1.9 added additional functions to enum classes
  • Make the testFixtures Java + Kotlin target explicit rather than implicit

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO]

    • No, v1 branch.
  • Any backward-incompatible changes? [NO]

  • Any new external dependencies? [NO]

    • No new dependencies but upgrades a few existing dependencies.
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Sep 10, 2024
Copy link

CROSS-ENGINE Conformance Report ❌

BASE (EVAL-E8A6566) TARGET (LEGACY-E8A6566) +/-
% Passing 94.22% 89.67% -4.55% ⭕
Passing 5555 5287 -268 ⭕
Failing 74 609 535 ⭕
Ignored 267 0 -267 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: e8a6566
  • Base Engine: EVAL
  • Target Commit: e8a6566
  • Target Engine: LEGACY

Result Details

  • ❌ REGRESSION DETECTED. See Now Failing Tests. ❌
  • Passing in both: 5019
  • Failing in both: 73
  • PASSING in BASE but now FAILING in TARGET: 536
  • FAILING in BASE but now PASSING in TARGET: 1

Now Failing Tests ❌

The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Now Passing Tests

The following 1 test(s) were previously FAILING in BASE but are now PASSING in TARGET. Before merging, confirm they are intended to pass:

Click here to see
  1. MYSQL_SELECT_29, compileOption: LEGACY

CROSS-COMMIT-EVAL Conformance Report ✅

BASE (EVAL-1DBB203) TARGET (EVAL-E8A6566) +/-
% Passing 94.22% 94.22% 0.00% ✅
Passing 5555 5555 0 ✅
Failing 74 74 0 ✅
Ignored 267 267 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 1dbb203
  • Base Engine: EVAL
  • Target Commit: e8a6566
  • Target Engine: EVAL

Result Details

  • Passing in both: 5555
  • Failing in both: 74
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 0

CROSS-COMMIT-LEGACY Conformance Report ✅

BASE (LEGACY-1DBB203) TARGET (LEGACY-E8A6566) +/-
% Passing 89.65% 89.67% 0.02% ✅
Passing 5286 5287 1 ✅
Failing 610 609 -1 ✅
Ignored 0 0 0 ✅
Total Tests 5896 5896 0 ✅

Testing Details

  • Base Commit: 1dbb203
  • Base Engine: LEGACY
  • Target Commit: e8a6566
  • Target Engine: LEGACY

Result Details

  • Passing in both: 5286
  • Failing in both: 609
  • PASSING in BASE but now FAILING in TARGET: 0
  • FAILING in BASE but now PASSING in TARGET: 1

Now Passing Tests

The following 1 test(s) were previously FAILING in BASE but are now PASSING in TARGET. Before merging, confirm they are intended to pass:

Click here to see
  1. MYSQL_SELECT_29, compileOption: LEGACY

Copy link
Member

@johnedquinn johnedquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alancai98 alancai98 merged commit 122244e into v1 Sep 16, 2024
14 checks passed
@alancai98 alancai98 deleted the v1-upgrade-1.9 branch September 16, 2024 23:41
rchowell pushed a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants