Fix antlr dep partiql-lang

[alancai98]

Relevant Issues

• None

Description

• Tries fixing the partiql-lang dependency on partiql-parser
• Since the ANTLR shading change (Shade antlr dependency for partiql-parser and partiql-lang #1439), any call to the PartiQLParserBuilder.standard() from the Maven release of 0.14.6 would result in a NoSuchMethodError when attempting to parse. This was due to a partiql-lang using its own ANTLR dependency rather than partiql-parser's shaded ANTLR dependency.
  • It was not detected sooner in the normal gradle build because we would previously only generate the shaded ANTLR dependency when publishing the jars to Maven.
  • We should have been using this configuration provided by the shadow plugin for multi-project builds.
• Simple reproduction case for previous failure w/ v0.14.6

// in build.gradle.kts
dependencies {
    implementation("org.partiql:partiql-lang-kotlin:0.14.6")
}

// in Main.kt
import org.partiql.lang.syntax.PartiQLParserBuilder

fun main(args: Array<String>) {
    val input = "SELECT 1 FROM <<>>"
    val parser = PartiQLParserBuilder.standard().build()
    println(parser.parseAstStatement(input))
}

above results in the following error:

Exception in thread "main" org.partiql.lang.syntax.ParserException: Unhandled exception.
	Evaluator Error: at line <UNKNOWN>, column <UNKNOWN>: internal error, <UNKNOWN> : <UNKNOWN>

	at org.partiql.lang.syntax.impl.PartiQLPigParser.parseAstStatement(PartiQLPigParser.kt:74)
	at MainKt.main(Main.kt:6)
Caused by: java.lang.NoSuchMethodError: 'void org.partiql.parser.antlr.PartiQLTokens.<init>(org.partiql.lang.thirdparty.antlr.v4.runtime.CharStream)'
	at org.partiql.lang.syntax.impl.PartiQLPigParser.createTokenStream$partiql_lang(PartiQLPigParser.kt:111)
	at org.partiql.lang.syntax.impl.PartiQLPigParser.parseQuery$partiql_lang(PartiQLPigParser.kt:95)
	at org.partiql.lang.syntax.impl.PartiQLPigParser.parseQuery(PartiQLPigParser.kt:85)
	at org.partiql.lang.syntax.impl.PartiQLPigParser.parseAstStatement(PartiQLPigParser.kt:58)
	... 1 more

Note that when using the PartiQLParserBuilder.experimental... rather than PartiQLParserBuilder.standard..., the query parses without errors.

Other Information

• Updated Unreleased Section in CHANGELOG: [YES]

• Any backward-incompatible changes? [NO]

• Any new external dependencies? [NO]

• Do your changes comply with the Contributing Guidelines
  and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

Conformance comparison report

	Base (6c314d2)	1075fbd	+/-
% Passing	92.54%	92.54%	0.00%
✅ Passing	5384	5384	0
❌ Failing	434	434	0
🔶 Ignored	0	0	0
Total Tests	5818	5818	0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (6c314d2) but now fail: 0

Number failing in Base (6c314d2) but now pass: 0

[alancai98]

Local testing within partiql-lang-kotlin

• gradle clean and build partiql-lang-kotlin -- all previous tests passed
• publishToMavenLocal

In a sample project

• Created a simple gradle project w/ org.partiql:partiql-lang-kotlin:0.14.7 dependency

// In build.gradle.kts
repositories {
    mavenCentral()
    mavenLocal()
}

dependencies {
    implementation("org.partiql:partiql-lang-kotlin:0.14.7")
}

and in

// Main.kt
import org.partiql.lang.syntax.PartiQLParserBuilder

fun main(args: Array<String>) {
    val input = "SELECT 1 FROM <<>>"
    val parser = PartiQLParserBuilder.standard().build()
    println(parser.parseAstStatement(input))
}

Verified that the reproduction case from PR description now works without an error.

Other validation

• Inspected the locally-published partiql-lang-kotlin-0.14.7.jar and checked that the ANTLR dependencies used in partiql-lang come from partiql-parser's shadowed ANTLR dependency under org.partiql.parser.thirdparty.antlr

[johnedquinn]

Tested locally. Thanks for tackling this issue!