Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initializes PartiQLData and PartiQLValueLoader #1443

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

johnedquinn
Copy link
Member

@johnedquinn johnedquinn commented Apr 23, 2024

Relevant Issues

  • None

Description

  • Initializes PartiQLData and PartiQLValueLoader.
  • I modeled this with JDBC's ResultSet and Ion's IonReader in mind.
  • I also updated PartiQLResult.Value to hold PartiQLData -- NOT a PartiQLValue.
  • Note: I decided to write this in Java.

Reviewer Notice

  • The second commit removes all CLI tests as the KOW branch's CLI has been completely overhauled causing this PR to fail the build. For the reviewer, I'd recommend reviewing the first commit by itself and then checking to see that I didn't accidentally delete any other files in the second commit.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@johnedquinn johnedquinn force-pushed the kow-reader branch 2 times, most recently from 34e2adf to c6e5a6a Compare April 24, 2024 18:11
@johnedquinn johnedquinn requested a review from rchowell April 24, 2024 18:11
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (kow@c1e2f1e). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff           @@
##             kow    #1443   +/-   ##
======================================
  Coverage       ?   77.74%           
  Complexity     ?     2507           
======================================
  Files          ?      254           
  Lines          ?    18554           
  Branches       ?     3510           
======================================
  Hits           ?    14425           
  Misses         ?     3128           
  Partials       ?     1001           
Flag Coverage Δ
EXAMPLES 80.07% <ø> (?)
LANG 77.68% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnedquinn johnedquinn merged commit a9888b8 into partiql:kow Apr 30, 2024
7 checks passed
@johnedquinn johnedquinn deleted the kow-reader branch April 30, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants