Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skips GPML conformance tests for new evaluator #1426

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Skips GPML conformance tests for new evaluator #1426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test/partiql-tests-runner/src/test/kotlin/org/partiql/runner/ConformanceTestBase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@ package org.partiql.runner
import org.junit.jupiter.api.Timeout
import org.junit.jupiter.params.ParameterizedTest
import org.junit.jupiter.params.provider.ArgumentsSource
import org.partiql.lang.eval.CompileOptions
import org.partiql.runner.schema.TestCase
import org.partiql.runner.test.TestProvider
import org.partiql.runner.test.TestRunner

abstract class ConformanceTestBase<T, V> {
abstract val runner: TestRunner<T, V>
abstract val skipListForEvaluation: List<Pair<String, CompileOptions>>
abstract val skipListForEquivalence: List<Pair<String, CompileOptions>>

// Tests the eval tests with the Kotlin implementation
// Unit is second.
Expand All @@ -20,7 +23,7 @@ abstract class ConformanceTestBase<T, V> {
@ArgumentsSource(TestProvider.Eval::class)
fun validatePartiQLEvalTestData(tc: TestCase) {
when (tc) {
is TestCase.Eval -> runner.test(tc, emptyList())
is TestCase.Eval -> runner.test(tc, skipListForEvaluation)
else -> error("Unsupported test case category")
}
}
Expand All @@ -31,7 +34,7 @@ abstract class ConformanceTestBase<T, V> {
@ArgumentsSource(TestProvider.Equiv::class)
fun validatePartiQLEvalEquivTestData(tc: TestCase) {
when (tc) {
is TestCase.Equiv -> runner.test(tc, emptyList())
is TestCase.Equiv -> runner.test(tc, skipListForEquivalence)
else -> error("Unsupported test case category")
}
}
Expand Down
Loading
Loading