Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves lang.eval sources back to partiql-lang #1412

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

johnedquinn
Copy link
Member

@johnedquinn johnedquinn commented Apr 3, 2024

Relevant Issues

  • None

Description

  • Moves lang.eval sources back to partiql-lang
  • I ran: git reset db1c85b0fcfccdf6e9c8069e45d48525cc81e947 -- partiql-lang/
  • Then, I deleted partiql-eval/src/main/kotlin/org.partiql.lang, partiql-eval/src/test/kotlin/org.partiql.lang

Other Information

  • Updated Unreleased Section in CHANGELOG: NO
  • Any backward-incompatible changes? NO, V1 is unreleased
  • Any new external dependencies? NO, just a move
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? YES

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v1@810035c). Click here to learn what that means.

Additional details and impacted files
@@          Coverage Diff          @@
##             v1    #1412   +/-   ##
=====================================
  Coverage      ?   71.01%           
  Complexity    ?     2239           
=====================================
  Files         ?      256           
  Lines         ?    18569           
  Branches      ?     3382           
=====================================
  Hits          ?    13187           
  Misses        ?     4436           
  Partials      ?      946           
Flag Coverage Δ
CLI 13.77% <ø> (?)
EXAMPLES 80.28% <ø> (?)
LANG 76.75% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnedquinn johnedquinn marked this pull request as ready for review April 4, 2024 16:13
@johnedquinn johnedquinn requested a review from rchowell April 4, 2024 16:13
Copy link
Contributor

@rchowell rchowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@rchowell rchowell merged commit 3db0221 into partiql:v1 Apr 5, 2024
7 checks passed
@johnedquinn johnedquinn deleted the v1-move-lang-eval branch April 11, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants