Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Releases v1.0.0-perf.1 #1381

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Conversation

johnedquinn
Copy link
Member

@johnedquinn johnedquinn commented Mar 4, 2024

Relevant Issues

  • None

Description

  • Releases 1.0.0-perf.1 (tag v1.0.0-perf.1) and sets up next development version.
  • SEE BOTH COMMITS. The first will be used to release the pre-release.
  • We follow SemVer to denote a pre-release:

A pre-release version MAY be denoted by appending a hyphen and a series of dot separated identifiers immediately following the patch version. Identifiers MUST comprise only ASCII alphanumerics and hyphens [0-9A-Za-z-]. Identifiers MUST NOT be empty. Numeric identifiers MUST NOT include leading zeroes. Pre-release versions have a lower precedence than the associated normal version. A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version. Examples: 1.0.0-alpha, 1.0.0-alpha.1, 1.0.0-0.3.7, 1.0.0-x.7.z.92, 1.0.0-x-y-z.--

SemVer Documentation

Other Information

  • Updated Unreleased Section in CHANGELOG: YES
  • Any backward-incompatible changes? YES
    • Yes, but this is a pre-release.
  • Any new external dependencies? NO
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? YES

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Mar 4, 2024

Conformance comparison report-Cross Engine

Base (eval) legacy +/-
% Passing 77.09% 92.51% 15.42%
✅ Passing 4485 5382 897
❌ Failing 1333 436 -897
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 4317

Number failing in both: 268

Number passing in eval engine but fail in legacy engine: 168

Number failing in eval engine but pass in legacy engine: 1065
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
1065 test(s) were failing in eval but now pass in legacy. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-EVAL

Base (e5a1e24) d162f80 +/-
% Passing 77.09% 77.09% 0.00%
✅ Passing 4485 4485 0
❌ Failing 1333 1333 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 4485

Number failing in both: 1333

Number passing in Base (e5a1e24) but now fail: 0

Number failing in Base (e5a1e24) but now pass: 0

Conformance comparison report-Cross Commit-LEGACY

Base (e5a1e24) d162f80 +/-
% Passing 92.54% 92.51% -0.03%
✅ Passing 5384 5382 -2
❌ Failing 434 436 2
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5382

Number failing in both: 434

Number passing in Base (e5a1e24) but now fail: 2

Number failing in Base (e5a1e24) but now pass: 0
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️. The following test(s) were previously passing but now fail:

Click here to see
  • MYSQL_SELECT_29, compileOption: PERMISSIVE
  • MYSQL_SELECT_29, compileOption: LEGACY

@johnedquinn johnedquinn marked this pull request as ready for review March 4, 2024 17:52

This is a pre-release containing:
- A new, experimental evaluator under `org.partiql.eval`.
- Several breaking changes under `org.partiql.plan` and `org.partiql.types` and `org.partiql.spi`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably at some point before v1.0.0, we should list out all of the breaking changes.

@johnedquinn johnedquinn merged commit 287a64a into partiql-eval Mar 4, 2024
10 checks passed
@johnedquinn johnedquinn deleted the partiql-eval-release-v1_0_0-perf_1 branch March 4, 2024 19:28
johnedquinn added a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants