Fix Join Hang

[yliuuuu]

Relevant Issues

• [Closes/Related To] Issue #XXX

Description

• Joins previously would hang if condition is false.
• This is because we missed moving the pointer for the RHS record to the next one.
• Also, small fix on the logic to insert ref into symbol.

Other Information

• Updated Unreleased Section in CHANGELOG: [YES/NO]

  • < If NO, why? >

• Any backward-incompatible changes? [YES/NO]

  • < If YES, why? >
  • < For this purpose, we define backward-incompatible changes as changes that—when consumed—can potentially result in
    errors for users that are using our public APIs or the entities that have public visibility in our code-base. >

• Any new external dependencies? [YES/NO]

  • < If YES, which ones and why? >
  • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >

• Do your changes comply with the Contributing Guidelines
  and Code Style Guidelines? [YES/NO]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

Conformance comparison report-Cross Engine

	Base (eval)	legacy	+/-
% Passing	77.84%	92.51%	14.66%
✅ Passing	4529	5382	853
❌ Failing	1289	436	-853
🔶 Ignored	0	0	0
Total Tests	5818	5818	0
Number passing in both: 4360

Number failing in both: 267

Number passing in eval engine but fail in legacy engine: 169

Number failing in eval engine but pass in legacy engine: 1022
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
1022 test(s) were failing in eval but now pass in legacy. Before merging, confirm they are intended to pass.
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-EVAL

	Base (a8cda41)	8782fd0	+/-
% Passing	77.52%	77.84%	0.33%
✅ Passing	4510	4529	19
❌ Failing	1308	1289	-19
🔶 Ignored	0	0	0
Total Tests	5818	5818	0
Number passing in both: 4510

Number failing in both: 1289

Number passing in Base (a8cda41) but now fail: 0

Number failing in Base (a8cda41) but now pass: 19
19 test(s) were previously failing but now pass. Before merging, confirm they are intended to pass
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

Conformance comparison report-Cross Commit-LEGACY

	Base (a8cda41)	8782fd0	+/-
% Passing	92.47%	92.51%	0.03%
✅ Passing	5380	5382	2
❌ Failing	438	436	-2
🔶 Ignored	0	0	0
Total Tests	5818	5818	0
Number passing in both: 5380

Number failing in both: 436

Number passing in Base (a8cda41) but now fail: 0

Number failing in Base (a8cda41) but now pass: 2
The following test(s) were previously failing but now pass. Before merging, confirm they are intended to pass:

Click here to see

• MYSQL_SELECT_23, compileOption: PERMISSIVE

• MYSQL_SELECT_23, compileOption: LEGACY

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (partiql-eval@a8cda41). Click here to learn what that means.

Additional details and impacted files

@@               Coverage Diff               @@
##             partiql-eval    #1380   +/-   ##
===============================================
  Coverage                ?   50.32%           
  Complexity              ?     1045           
===============================================
  Files                   ?      165           
  Lines                   ?    13129           
  Branches                ?     2452           
===============================================
  Hits                    ?     6607           
  Misses                  ?     5862           
  Partials                ?      660           

Flag	Coverage Δ
CLI	13.77% <ø> (?)
EXAMPLES	80.28% <ø> (?)
LANG	54.71% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.