Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds UNPIVOT, LIMIT, and OFFSET to partiql-eval #1364

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

rchowell
Copy link
Contributor

@rchowell rchowell commented Feb 7, 2024

Description

This adds UNPIVOT, LIMIT, and OFFSET to partiql-eval. We will need to update LIMIT and OFFSET to use the upvalues introduced in John's correlated subquery PR.

Other Information

  • Updated Unreleased Section in CHANGELOG: [YES/NO]
    N/A

  • Any backward-incompatible changes? [YES/NO]
    No

  • Any new external dependencies? [YES/NO]

    • < If YES, which ones and why? >
    • < In addition, please also mention any other alternatives you've considered and the reason they've been discarded >
      No
  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES/NO]
    Yes

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchowell rchowell requested a review from yliuuuu February 7, 2024 19:13
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (partiql-eval@c8f9060). Click here to learn what that means.

Additional details and impacted files
@@               Coverage Diff               @@
##             partiql-eval    #1364   +/-   ##
===============================================
  Coverage                ?   50.32%           
  Complexity              ?     1045           
===============================================
  Files                   ?      165           
  Lines                   ?    13129           
  Branches                ?     2452           
===============================================
  Hits                    ?     6607           
  Misses                  ?     5862           
  Partials                ?      660           
Flag Coverage Δ
CLI 13.77% <0.00%> (?)
EXAMPLES 80.28% <0.00%> (?)
LANG 54.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 7, 2024

Conformance comparison report-Cross Engine

Base (legacy) eval +/-
% Passing 92.47% 55.12% -37.35%
✅ Passing 5380 3207 -2173
❌ Failing 438 2611 2173
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 3204

Number failing in both: 435

Number passing in legacy engine but fail in eval engine: 2176

Number failing in legacy engine but pass in eval engine: 3
⁉️ CONFORMANCE REPORT REGRESSION DETECTED ⁉️
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.
The following test(s) are failing in legacy but pass in eval. Before merging, confirm they are intended to pass:

Click here to see
  • missing and true, compileOption: PERMISSIVE

  • nullif valid cases{first:"missing",second:"missing",result:missing}, compileOption: PERMISSIVE

  • nullif valid cases{first:"missing",second:"missing",result:missing}, compileOption: LEGACY

Conformance comparison report-Cross Commit-LEGACY

Base (c8f9060) be3daf6 +/-
% Passing 92.47% 92.47% 0.00%
✅ Passing 5380 5380 0
❌ Failing 438 438 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 5380

Number failing in both: 438

Number passing in Base (c8f9060) but now fail: 0

Number failing in Base (c8f9060) but now pass: 0

Conformance comparison report-Cross Commit-EVAL

Base (c8f9060) be3daf6 +/-
% Passing 54.86% 55.12% 0.26%
✅ Passing 3192 3207 15
❌ Failing 2626 2611 -15
🔶 Ignored 0 0 0
Total Tests 5818 5818 0
Number passing in both: 3192

Number failing in both: 2611

Number passing in Base (c8f9060) but now fail: 0

Number failing in Base (c8f9060) but now pass: 15
15 test(s) were previously failing but now pass. Before merging, confirm they are intended to pass
The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact.

@rchowell rchowell merged commit 8f3c7f2 into partiql-eval Feb 7, 2024
10 checks passed
@rchowell rchowell deleted the partiql-eval-unpivot branch February 7, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants