-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the unsafe DECIMAL to integer downcasts #1342
Conversation
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (1e1a71f) but now fail: 0 Number failing in Base (1e1a71f) but now pass: 0 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
============================================
- Coverage 72.17% 72.15% -0.02%
+ Complexity 2097 2095 -2
============================================
Files 221 221
Lines 15973 15984 +11
Branches 2892 2896 +4
============================================
+ Hits 11528 11534 +6
- Misses 3639 3641 +2
- Partials 806 809 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/TypeLattice.kt
Outdated
Show resolved
Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/typer/TypeLattice.kt
Show resolved
Hide resolved
INT8 to unsafe(), | ||
INT16 to unsafe(), | ||
INT32 to unsafe(), | ||
INT64 to unsafe(), | ||
INT to unsafe(), | ||
DECIMAL to unsafe(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make those explicit as well, for consistent with DECIMAL since right now we are kind of inflating those two types during inferring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Relevant Issues
The following explicit/unsafe casts were missing in the type definitions.
Description
Adds the unsafe DECIMAL to integer downcasts.
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
No
Any backward-incompatible changes? [YES/NO]
No
Any new external dependencies? [YES/NO]
No
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.