Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-adds removed builder APIs and adds deprecation notice #1327

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

johnedquinn
Copy link
Member

@johnedquinn johnedquinn commented Jan 2, 2024

Relevant Issues

Description

  • Re-adds removed builder APIs and adds deprecation notice
  • I went through the JAPI compliance checker. Based on that, followed the guidance.
  • This is a pre-req to v0.14.1 release.

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Jan 2, 2024

Conformance comparison report

Base (c73efbf) 36a675d +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (c73efbf) but now fail: 0

Number failing in Base (c73efbf) but now pass: 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c73efbf) 72.17% compared to head (fcd061b) 72.17%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1327   +/-   ##
=========================================
  Coverage     72.17%   72.17%           
  Complexity     2097     2097           
=========================================
  Files           221      221           
  Lines         15973    15973           
  Branches       2892     2892           
=========================================
  Hits          11528    11528           
  Misses         3639     3639           
  Partials        806      806           
Flag Coverage Δ
CLI 11.86% <ø> (ø)
EXAMPLES 80.28% <ø> (ø)
LANG 80.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnedquinn johnedquinn marked this pull request as ready for review January 2, 2024 23:35
@johnedquinn johnedquinn merged commit 8253053 into main Jan 2, 2024
10 checks passed
@johnedquinn johnedquinn deleted the deprecates-builder-apis branch January 2, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants