Adds unary, logical, binary arithmetic, and concat operators

[johnedquinn]

Relevant Issues

• None

Description

• Adds:
  • Logical Operators (NOT, AND, OR)
  • Unary Operators (POS, NEG)
  • Binary Arithmetic Operators (PLUS, MINUS, TIMES, DIV, MOD, BITWISE-AND)
  • Concat Operator

Other Information

• Updated Unreleased Section in CHANGELOG: NO
• Any backward-incompatible changes? NO
• Any new external dependencies? NO
• Do your changes comply with the Contributing Guidelines
  and Code Style Guidelines? YES

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[github-actions]

Conformance comparison report

	Base (c7466e4)	3955836	+/-
% Passing	92.54%	92.54%	0.00%
✅ Passing	5384	5384	0
❌ Failing	434	434	0
🔶 Ignored	0	0	0
Total Tests	5818	5818	0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (c7466e4) but now fail: 0

Number failing in Base (c7466e4) but now pass: 0

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (partiql-plugin-impl@c7466e4). Click here to learn what that means.

Additional details and impacted files

@@                  Coverage Diff                   @@
##             partiql-plugin-impl    #1325   +/-   ##
======================================================
  Coverage                       ?   49.27%           
  Complexity                     ?     1046           
======================================================
  Files                          ?      166           
  Lines                          ?    13395           
  Branches                       ?     2504           
======================================================
  Hits                           ?     6600           
  Misses                         ?     6138           
  Partials                       ?      657           

Flag	Coverage Δ
CLI	11.86% <0.00%> (?)
EXAMPLES	80.28% <0.00%> (?)
LANG	54.71% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rchowell]

not sure these handle divide by zero, but perhaps that's out-of-scope for the initial PR. I think using reified type parameters would allow using the operators rather than a function call

binaryOpInt8(args) { lhs, rhs ->
   if (rhs == 0) {
         // handle error
   }
   val result = lhs / rhs
   return int8Value(result)
}

Not sure that code works for byte division, but the point is to pass our own block rather than Byte::div so we can handle the unpacked arguments ourselves on a per-function basis. See check for an example

[rchowell]

This all looks good. Note that it does assume we are doing null call handling in the call operator within eval. This assumption is probably the right call so that every operator doesn't have to repeat logic