Initializes bindings in connectors and globals #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5384 Number failing in both: 434 Number passing in Base (480c903) but now fail: 0 Number failing in Base (480c903) but now pass: 0 |
johnedquinn
requested changes
Dec 19, 2023
plugins/partiql-memory/src/main/kotlin/org/partiql/plugins/memory/MemoryBindings.kt
Outdated
Show resolved
Hide resolved
plugins/partiql-memory/src/main/kotlin/org/partiql/plugins/memory/MemoryBindings.kt
Outdated
Show resolved
Hide resolved
65b62c4 to
7476b17
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## partiql-eval #1317 +/- ##
===============================================
Coverage ? 49.26%
Complexity ? 1046
===============================================
Files ? 166
Lines ? 13396
Branches ? 2504
===============================================
Hits ? 6600
Misses ? 6139
Partials ? 657
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
johnedquinn
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a getBindings() method to PartiQL Plugins. A plugin will return a PartiQLBindings object which returns a PartiQLValue given a ConnectorObjectPath.
I have implemented this for the MemoryPlugin which is now used to load globals from the conformance test suite. This PR also includes an implementation of a TestExecutor for the ongoing evaluator work.
and Code Style Guidelines? [YES/NO]
Yes
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.