Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jmh benchmark after #1309 #1312

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix jmh benchmark after #1309 #1312

merged 1 commit into from
Dec 15, 2023

Conversation

alancai98
Copy link
Member

Description

JMH benchmark was using the old PartiQLParserBuilder.standard().build() to create the parser. Following #1309, JMH benchmark GH actions CI broke. Changed to use PartiQLParser.default().

Other Information

  • Updated Unreleased Section in CHANGELOG: [NO]

    • No change to public api
  • Any backward-incompatible changes? [NO]

  • Any new external dependencies? [NO]

  • Do your changes comply with the Contributing Guidelines
    and Code Style Guidelines? [YES]

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 self-assigned this Dec 15, 2023
Copy link

Conformance comparison report

Base (dafdac5) 36b8032 +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (dafdac5) but now fail: 0

Number failing in Base (dafdac5) but now pass: 0

@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dafdac5) 72.16% compared to head (4b8ed48) 72.16%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1312   +/-   ##
=========================================
  Coverage     72.16%   72.16%           
  Complexity     2097     2097           
=========================================
  Files           221      221           
  Lines         15974    15974           
  Branches       2892     2892           
=========================================
  Hits          11528    11528           
  Misses         3640     3640           
  Partials        806      806           
Flag Coverage Δ
CLI 11.86% <ø> (ø)
EXAMPLES 80.28% <ø> (ø)
LANG 80.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rchowell rchowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@alancai98 alancai98 merged commit c489057 into main Dec 15, 2023
@alancai98 alancai98 deleted the fix-jmh-benchmark branch December 15, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants