Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor modeling of EXCLUDE in partiql-ast and partiql-plan #1311

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

alancai98
Copy link
Member

Description

Refactors the modeling of EXCLUDE in the partiql-ast and partiql-plan. Changes include

  • EXCLUDE root modeled as a variable reference rather than an identifier symbol
  • EXCLUDE wildcard steps modeled using an enum to differentiate between the two types (tuple vs collection)
  • Change EXCLUDE class names in partiql-ast to align w/ the partiql-plan modeling

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@alancai98 alancai98 requested a review from rchowell December 15, 2023 01:48
@alancai98 alancai98 self-assigned this Dec 15, 2023
@alancai98 alancai98 force-pushed the refactor-exclude-in-plan branch from 4705061 to 434f38a Compare December 15, 2023 01:49
Copy link

github-actions bot commented Dec 15, 2023

Conformance comparison report

Base (0a75bd3) cc70602 +/-
% Passing 92.54% 92.54% 0.00%
✅ Passing 5384 5384 0
❌ Failing 434 434 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5384

Number failing in both: 434

Number passing in Base (0a75bd3) but now fail: 0

Number failing in Base (0a75bd3) but now pass: 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (79ee005) 72.36% compared to head (434f38a) 72.36%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1311   +/-   ##
=========================================
  Coverage     72.36%   72.36%           
  Complexity     2099     2099           
=========================================
  Files           221      221           
  Lines         15974    15974           
  Branches       2892     2892           
=========================================
  Hits          11559    11559           
  Misses         3600     3600           
  Partials        815      815           
Flag Coverage Δ
CLI 13.41% <ø> (ø)
EXAMPLES 80.28% <ø> (ø)
LANG 80.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alancai98 alancai98 force-pushed the refactor-exclude-in-plan branch from 434f38a to bb4a2e2 Compare December 15, 2023 20:16
@alancai98 alancai98 requested a review from rchowell December 15, 2023 20:19
@alancai98 alancai98 merged commit dafdac5 into main Dec 15, 2023
@alancai98 alancai98 deleted the refactor-exclude-in-plan branch December 15, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants