Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for EXCLUDE in the default SqlDialect #1285

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

johnedquinn
Copy link
Member

Relevant Issues

  • None

Description

  • Adds support for EXCLUDE in the default SqlDialect

Other Information

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Dec 7, 2023

Conformance comparison report

Base (f8f6b2a) f3f9b49 +/-
% Passing 92.33% 92.33% 0.00%
✅ Passing 5372 5372 0
❌ Failing 446 446 0
🔶 Ignored 0 0 0
Total Tests 5818 5818 0

Number passing in both: 5372

Number failing in both: 446

Number passing in Base (f8f6b2a) but now fail: 0

Number failing in Base (f8f6b2a) but now pass: 0

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8f6b2a) 72.20% compared to head (8a37a9a) 72.20%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1285   +/-   ##
=========================================
  Coverage     72.20%   72.20%           
  Complexity     2100     2100           
=========================================
  Files           222      222           
  Lines         16019    16019           
  Branches       2891     2891           
=========================================
  Hits          11567    11567           
  Misses         3635     3635           
  Partials        817      817           
Flag Coverage Δ
CLI 13.43% <ø> (ø)
EXAMPLES 80.28% <ø> (ø)
LANG 80.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnedquinn johnedquinn marked this pull request as ready for review December 8, 2023 00:30
@johnedquinn johnedquinn requested a review from alancai98 December 8, 2023 00:30
@johnedquinn johnedquinn merged commit 7c9cc9a into main Dec 8, 2023
@johnedquinn johnedquinn deleted the exclude-dialect branch December 8, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants