Fix Timestamp Type Parsing Issue. #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance comparison report
Number passing in both: 5372 Number failing in both: 446 Number passing in Base (6ba5a12) but now fail: 0 Number failing in Base (6ba5a12) but now pass: 0 |
johnedquinn
reviewed
Dec 8, 2023
Comment on lines
+368
to
+378
| @Test | ||
| fun callIsTimestamp() = assertExpression( | ||
| "t1 IS TIMESTAMP", | ||
| "(is_type (id t1 (case_insensitive) (unqualified)) (timestamp_type null))" | ||
| ) | ||
|
|
||
| @Test | ||
| fun callIsTime() = assertExpression( | ||
| "t1 IS TIME", | ||
| "(is_type (id t1 (case_insensitive) (unqualified)) (time_type null))" | ||
| ) |
There was a problem hiding this comment.
Just to avoid potential failures in the future, can you also add the WITH TIME ZONE test to each?
There was a problem hiding this comment.
Added Tests for Time Zone And Precision.
There was a problem hiding this comment.
Did you forget to push? I don't see any changes rn.
There was a problem hiding this comment.
Sorry the push command failed due to a rebased...
johnedquinn
approved these changes
Dec 8, 2023
alancai98
added a commit
that referenced
this pull request
Dec 12, 2023
* Adds support for EXCLUDE in the SqlDialect * fix typer/transfomrer * Fix Timestamp Type Parsing Issue. (#1284) * fix timestamp type parsing issue * Refactors partiql-tests-runner for multiple engines (#1289) * Adds int32 and int64 variants of date_add (#1291) * Adds support for DISTINCT in the Planner * Fix PlanCompiler output type for DISTINCT + ORDER BY (#1298) * Fixes scan_indexed and adds PIVOT (#1297) * Port filter_distinct fix to partiql-eval internal --------- Co-authored-by: John Ed Quinn <johqunn@amazon.com> Co-authored-by: Yingtao Liu <yliuuu@amazon.com> Co-authored-by: yliuuuu <107505258+yliuuuu@users.noreply.github.com> Co-authored-by: John Ed Quinn <40360967+johnedquinn@users.noreply.github.com> Co-authored-by: R. C. Howell <RCHowell@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Issues
Description
Other Information
Updated Unreleased Section in CHANGELOG: [YES/NO]
Any backward-incompatible changes? [YES/NO]
Any new external dependencies? [YES/NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [YES/NO]
Yes.
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.